Skip to content

Write-Object -NoEnumerate should not wrap sigular object #5123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
PetSerAl wants to merge 5 commits into from
Closed

Write-Object -NoEnumerate should not wrap sigular object #5123

PetSerAl wants to merge 5 commits into from

Conversation

@PetSerAl
Copy link
Contributor

@PetSerAl PetSerAl commented Oct 15, 2017 •
edited
Loading

Fix #5122
I decide to make ValueFromRemainingArguments to always unwrap single argument, even if it is not collection. Otherwise it would be impossible to distinguish two cases:

Write-Object -NoEnumerate 1
Write-Object -NoEnumerate ( [System.Collections.Generic.List[object]]::new((,1)) )

@iSazonov
Copy link
Collaborator

iSazonov commented Oct 15, 2017

@PetSerAl What is the last commit? Need rebase?

@PetSerAl
Copy link
Contributor Author

PetSerAl commented Oct 15, 2017

@iSazonov I am cherry pick first commit from #5109, to make sure that tests pass too, since my change is more strong then proposed here. I think it would be more consistent to unwrap any single parameter passed as ValueFromRemainingArguments, while #5109 propose to unwrap only collections.

@daxian-dbw daxian-dbw mentioned this pull request Oct 15, 2017
Merged
@iSazonov
Copy link
Collaborator

iSazonov commented Oct 16, 2017

@PetSerAl @mklement0 Please see latest comments in #5109 about the PR.

@PetSerAl PetSerAl closed this Oct 19, 2017
@iSazonov
Copy link
Collaborator

iSazonov commented Oct 19, 2017 •
edited
Loading

@PetSerAl Please add comment why the Issue was closed.

@PetSerAl
Copy link
Contributor Author

PetSerAl commented Oct 26, 2017

@iSazonov Given this comment and that #5109 is now merged, I do not see how my changes in binder can be accepted. And I do not see other way to fix #5122, thus I see no value in keeping this PR open. I do not closing #5122 though. If someone know how to fix it, then them can submit their own PR instead of this one.

@mklement0 mklement0 mentioned this pull request Nov 26, 2017
Closed
@PetSerAl PetSerAl deleted the fix-write-object-noenumerate-sigular-object branch August 22, 2018 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BrucePay BrucePay Awaiting requested review from BrucePay

@dantraMSFT dantraMSFT Awaiting requested review from dantraMSFT

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@JamesWTruher JamesWTruher Awaiting requested review from JamesWTruher

@lzybkr lzybkr Awaiting requested review from lzybkr

@PaulHigin PaulHigin Awaiting requested review from PaulHigin

@vors vors Awaiting requested review from vors

Assignees

@lzybkr lzybkr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@PetSerAl @iSazonov @lzybkr @dlwyatt