Fix MatchInfoContext Clone implementation #5121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old implementation always set the new object's properties to null
dee-see
requested review from
JamesWTruher,
PaulHigin and
dantraMSFT
as code owners
lzybkr
approved these changes
Oct 17, 2017
Contributor
lzybkr
left a comment
lzybkr
left a comment
There was a problem hiding this comment.
Code change is fine.
A test would be nice, ideally failing if a new property is introduced but not cloned. That might be hard, so just checking the number of properties and a good comment might be sufficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3994
The old implementation always set the new object's properties to null.
The original issue mentioned that the other
Cloneimplementation in MatchString.cs had the same bug, but in fact it's correct because of the use ofMemberwiseClone.I didn't much unit testing of C# code going on in the project (or maybe I missed it?). Should I add a test and if so, where?