put command discovery before scripts for Unix #5116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iSazonov
reviewed
Oct 14, 2017
| $env:PATH = $originalPath | ||
| } | ||
|
|
||
| It "Should return a type of 'string' for hostname cmdlet" { |
Collaborator
There was a problem hiding this comment.
Now we skip the test - why?
Member
Author
There was a problem hiding this comment.
This test was created a long time ago. I think it's actually not useful and is implicitly covered by tests that follow. I'll remove it.
iSazonov
approved these changes
Oct 14, 2017
Collaborator
iSazonov
left a comment
iSazonov
left a comment
There was a problem hiding this comment.
LGTM with one minor comment.
anmenaga
approved these changes
Oct 17, 2017
Member
Author
|
@anmenaga I was thinking that would be a good way for command discovery to find the "native command" and the powershell script to validate the command was executed over the script without polluting the current working directory. |
Member
Author
|
@mirichmo can you merge? |
Member
|
Is this change only for Unix? The title seems so but the change is not guarded by |
mirichmo
approved these changes
Oct 24, 2017
Member
|
@daxian-dbw The code is guarded by a runtime Platform check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also cleaned up the NativeLinuxCommands.Tests.ps1 script on skipping tests
Fix #2095