remove Get-PSHostProcessInfo under non-windows platform #5105
Conversation
chunqingchen
requested review from
BrucePay,
daxian-dbw,
lzybkr and
vors
as code owners
| } | ||
|
|
||
| Describe "Verify remoting cmdlets that should not be implemented under non-windows platform" -Tags @("CI") { | ||
| It "Get-PSHostProcessInfo should be removed under non-windows platform" -Skip $IsWindows { |
There was a problem hiding this comment.
We already have the test in DefaultCommands.Tests.ps1
There was a problem hiding this comment.
As @iSazonov pointed out, the test DefaultCommands.Tests.ps1 covers available cmdlets on different plats by default, can you please update that test?
| #if !UNIX | ||
| {"Disable-PSRemoting", new SessionStateCmdletEntry("Disable-PSRemoting", typeof(DisablePSRemotingCommand), helpFile) }, | ||
| {"Enable-PSRemoting", new SessionStateCmdletEntry("Enable-PSRemoting", typeof(EnablePSRemotingCommand), helpFile) }, | ||
| {"Get-PSHostProcessInfo", new SessionStateCmdletEntry("Get-PSHostProcessInfo", typeof(GetPSHostProcessInfoCommand), helpFile) }, |
There was a problem hiding this comment.
What about Enter-PSHostProcess and Exit-PSHostProcess? They are supposed to work with Get-PSHostProcessInfo. Maybe we should exclude them all? @PaulHigin thoughts?
There was a problem hiding this comment.
Yes, these cmdlets should be exluded as well.
| } | ||
|
|
||
| Describe "Verify remoting cmdlets that should not be implemented under non-windows platform" -Tags @("CI") { | ||
| It "Get-PSHostProcessInfo should be removed under non-windows platform" -Skip $IsWindows { |
There was a problem hiding this comment.
As @iSazonov pointed out, the test DefaultCommands.Tests.ps1 covers available cmdlets on different plats by default, can you please update that test?
4 participants
this is to resolve #5081
since api-ms-win-core-file-l1-1-0.dll is not supported under non-windows platform, remove the cmdlet