Skip to content

Minor update to building/internals.md #5095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityapatwardhan merged 1 commit into from
Oct 13, 2017
Merged

Minor update to building/internals.md #5095

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions docs/building/internals.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Dummy dependencies allows us to build just `$Top` folder, instead of building se
### Dummy dependencies rules

If assembly is part of CoreCLR build,
it should be listed as a dependency for $Top folder (src\powershell-unix or src\powershell-win-core)
it should be listed as a dependency for `$Top` folder (`src\powershell-unix` or `src\powershell-win-core`)

## Preliminary steps

Expand Down Expand Up @@ -59,9 +59,7 @@ you likely need to delete the `gen` folders and re-run the tool.

### Type Catalog

As a work-around for the lack of `GetAssemblies()`,
our custom assembly load context takes a pre-generated catalog of C# types
(for PowerShell type resolution).
A pre-generated catalog of C# types is used in PowerShell to help type resolution.
Copy link
Member

@adityapatwardhan adityapatwardhan Oct 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 71 and below needs to be updated. CorePsTypeCatalog.ps is not under AssemblyLoadContext anymore.

Copy link
Member Author

@daxian-dbw daxian-dbw Oct 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Will fix.

Copy link
Member Author

@daxian-dbw daxian-dbw Oct 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, forgot it. That one will be addressed by #5072. That PR is pending merging.

Copy link
Member

@adityapatwardhan adityapatwardhan Oct 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge this once #5072 is merged.

Copy link
Member Author

@daxian-dbw daxian-dbw Oct 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just merged #5072 :)

Generating this catalog is a pre-build step that is run via `Start-TypeGen`,
which `Start-PSBuild` calls.
Again, however, PowerShell is not required.
Expand Down