Minor update to building/internals.md #5095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityapatwardhan
requested changes
Oct 12, 2017
| As a work-around for the lack of `GetAssemblies()`, | ||
| our custom assembly load context takes a pre-generated catalog of C# types | ||
| (for PowerShell type resolution). | ||
| A pre-generated catalog of C# types is used in PowerShell to help type resolution. |
Member
There was a problem hiding this comment.
Line 71 and below needs to be updated. CorePsTypeCatalog.ps is not under AssemblyLoadContext anymore.
Member
Author
There was a problem hiding this comment.
Good catch. Will fix.
Member
Author
There was a problem hiding this comment.
Oh, forgot it. That one will be addressed by #5072. That PR is pending merging.
adityapatwardhan
approved these changes
Oct 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #5072 (comment), this is a minor update to the
building/internals.md