You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Internals.md updated to use the new System.Management.Automation dll required for TypeCatalogGen.
Also, build.sh no longer exists, so I added the custom msbuild target to the instructions.
Out of the PR. @daxian-dbw About "lack of GetAssemblies()" - it seems .Net Core 2.0 has it. Can we remove TypeCatalogGen? I don't found a tracking Issue.
@iSazonov we cannot remove TypeCatalogGen. When you use a type like [System.Net.Http.HttpClient], the type catalog generated by TypeCatalogGen kicks in to figure out which assembly should be loaded. The type catalog also plays a role when you are doing a tab completion on a type like [httpcl<tab>. The reason is that GetAssemblies() can only give you the loaded assemblies, so without the type catalog, you need to make sure System.Net.Http.dll is loaded before using any types from it.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internals.md updated to use the new System.Management.Automation dll required for TypeCatalogGen.
Also, build.sh no longer exists, so I added the custom msbuild target to the instructions.