Fix Travis-CI macOS run #5065
Merged
Fix Travis-CI macOS run #5065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveL-MSFT
requested review from
TravisEz13,
adityapatwardhan and
daxian-dbw
as code owners
SteveL-MSFT
force-pushed
the
macos-travis
branch
2 times, most recently
from
596eddf to
84ca934
Compare
SteveL-MSFT
changed the title
SteveL-MSFT
force-pushed
the
macos-travis
branch
7 times, most recently
from
4fb6091 to
8b86f5b
Compare
SteveL-MSFT
changed the title
Commented out check for sudo as it was failing on Travis-CI Updated version of Ruby to 2.3.3 Reorder install so Ruby gets installed before installing PS as Homebrew relies on Ruby 2.3 Remove sudo check which breaks Travis-CI
SteveL-MSFT
force-pushed
the
macos-travis
branch
from
8b86f5b to
b59953e
Compare
TravisEz13
reviewed
Oct 9, 2017
| exit 5 | ||
| fi | ||
| fi | ||
| #if [[ "$SUDO" -eq "sudo" ]]; then |
Member
There was a problem hiding this comment.
We should remove this commented code if it's not needed. Perhaps we can wait until someone complains before making further changes.
Member
Author
There was a problem hiding this comment.
It's not clear to me if this is needed for local execution of this script or if anyone actually uses these scripts locally outside of CI
TravisEz13
approved these changes
Oct 9, 2017
nijel
added a commit
to phpmyadmin/phpmyadmin
that referenced
this pull request
Oct 10, 2017
Based on PowerShell/PowerShell#5065 Signed-off-by: Michal Čihař <michal@cihar.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some formatting and output issues. Main fix to get the build working is moving
brew updateearlier (thanks @TravisEz13). Removed sudo check as it fails on Travis-CIFix #5062