Replace HttpBin.org/response-headers Tests with WebListener #5058
Conversation
markekraus
requested review from
TravisEz13,
adityapatwardhan and
daxian-dbw
as code owners
iSazonov
left a comment
iSazonov
left a comment
There was a problem hiding this comment.
LGTM with two minor comments.
| #region test/tools/WebListener/README.md Overrides | ||
| - test/tools/WebListener/README.md | ||
| ResponseHeaders | ||
| #endregion |
There was a problem hiding this comment.
Are they really all used?
There was a problem hiding this comment.
I'm not sure what you are asking. But, I added a file level override because I had been putting all of the overrides for this in the Global dictionary. That was probably a poor decision, so I'm adding the new section and will do a separate PR after this is merged to move the ones from my previous PRs from global to the file override.
| } | ||
| return JsonConvert.SerializeObject(headers); | ||
| } | ||
| public IActionResult Error() |
|
Travis CI fail due to #5062 |
|
@markekraus MSFT maintainers address such issues very fast. Be patient :-) |
|
@iSazonov they do 😄. But the community can also address them if an issue is filed. Besides, I prefer to have an issue that explains why my PRs are failing externally. Makes it easier to track when the external issue has been resolved to move forward. @SteveL-MSFT would likely create an issue for this when he came online anyway. I'm no no hurry, just trying to be helpful and thorough. |
|
@markekraus looking at the Mac issue, restarted your build for now |
|
@TravisEz13 Is there something outstanding on this PR I need to do? |
4 participants
/ResponseHeaders/Test to WebListener-Queryparameter toGet-WebListenerUrlwhich accepts a dictionary where keys are wuery string fields and values are query string valuesReference #2504
(note: the tests as they were intended before were actually not accurate. http://httpbin.org/response-headers returns an
Content-Type: application/jsonin addition toContent-Type:from the supplied header. The implementation in this PR does allow for a blank/missingContent-Typeto be returned. It is possible this may reveal errors that were not visible before.)