Skip to content

Make SemanticVersion compatible with SemVer 2.0 #5037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daxian-dbw merged 8 commits into from
Nov 9, 2017
Merged

Make SemanticVersion compatible with SemVer 2.0 #5037

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b176762
Make SemanticVersion compatible with SymVer 2.0
iSazonov Oct 6, 2017
777628f
Address feedback
iSazonov Nov 2, 2017
9571e06
Remove duplicate checks and add comment.
iSazonov Nov 5, 2017
3654b0f
Remove "s_' prefix from constant names
iSazonov Nov 7, 2017
2a7adce
Fix comments and names.
iSazonov Nov 7, 2017
5193501
Fix Compare(), GetHashCode() and add comments.
iSazonov Nov 7, 2017
69e0355
Fix tests
iSazonov Nov 7, 2017
2836c8b
[Feature] Address comment and fix immature replacement
daxian-dbw Nov 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions ...stem.Management.Automation/FormatAndOutput/DefaultFormatters/DotNetTypes_format_ps1xml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,14 @@ internal static IEnumerable<ExtendedTypeDefinition> GetFormatData()
"System.Version",
ViewsOf_System_Version());

yield return new ExtendedTypeDefinition(
"System.Version#IncludeLabel",
ViewsOf_System_Version_With_Label());

yield return new ExtendedTypeDefinition(
"System.Management.Automation.SemanticVersion",
ViewsOf_Semantic_Version_With_Label());

yield return new ExtendedTypeDefinition(
"System.Drawing.Printing.PrintDocument",
ViewsOf_System_Drawing_Printing_PrintDocument());
Expand Down Expand Up @@ -478,6 +486,46 @@ private static IEnumerable<FormatViewDefinition> ViewsOf_System_Version()
.EndTable());
}

private static IEnumerable<FormatViewDefinition> ViewsOf_System_Version_With_Label()
{
yield return new FormatViewDefinition("System.Version",
TableControl.Create()
.AddHeader(width: 6)
.AddHeader(width: 6)
.AddHeader(width: 6)
.AddHeader(width: 8)
.AddHeader(width: 26)
.AddHeader(width: 27)
.StartRowDefinition()
.AddPropertyColumn("Major")
.AddPropertyColumn("Minor")
.AddPropertyColumn("Build")
.AddPropertyColumn("Revision")
.AddPropertyColumn("PSSemVerPreReleaseLabel")
.AddPropertyColumn("PSSemVerBuildLabel")
.EndRowDefinition()
.EndTable());
}

private static IEnumerable<FormatViewDefinition> ViewsOf_Semantic_Version_With_Label()
{
yield return new FormatViewDefinition("System.Management.Automation.SemanticVersion",
TableControl.Create()
.AddHeader(width: 6)
.AddHeader(width: 6)
.AddHeader(width: 6)
.AddHeader(width: 9)
.AddHeader(width: 11)
.StartRowDefinition()
.AddPropertyColumn("Major")
.AddPropertyColumn("Minor")
.AddPropertyColumn("Patch")
.AddPropertyColumn("PreReleaseLabel")
.AddPropertyColumn("BuildLabel")
.EndRowDefinition()
.EndTable());
}

private static IEnumerable<FormatViewDefinition> ViewsOf_System_Drawing_Printing_PrintDocument()
{
yield return new FormatViewDefinition("System.Drawing.Printing.PrintDocument",
Expand Down
Loading