Skip to content

enable using filesystem from a UNC location #4998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityapatwardhan merged 5 commits into from
Oct 9, 2017
Merged

enable using filesystem from a UNC location #4998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
04c9ab9
enable using filesystem from a UNC location
SteveL-MSFT Oct 3, 2017
7d4db21
[feature]
SteveL-MSFT Oct 4, 2017
cf3736c
[feature]
SteveL-MSFT Oct 4, 2017
070f70b
added variations of tests for set-location and push-location
SteveL-MSFT Oct 4, 2017
87b153c
[feature]
SteveL-MSFT Oct 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/System.Management.Automation/namespaces/FileSystemProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4817,6 +4817,13 @@ protected override string GetParentPath(string path, string root)
{
parentPath = EnsureDriveIsRooted(parentPath);
}
#if !UNIX
else if (parentPath.Equals(StringLiterals.DefaultPathSeparatorString, StringComparison.Ordinal))
{
// make sure we return two backslashes so it still results in a UNC path
parentPath = "\\\\";
}
#endif
return parentPath;
} // GetParentPath

Expand Down
21 changes: 21 additions & 0 deletions test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1301,3 +1301,24 @@ Describe "Extended FileSystem Path/Location Cmdlet Provider Tests" -Tags "Featur
}
}
}

Describe "UNC paths" -Tags 'CI' {
It "Can Get-ChildItems from a UNC location using <cmdlet>" -Skip:(!$IsWindows) -TestCases @(
@{cmdlet="Push-Location"},
@{cmdlet="Set-Location"}
) {
param($cmdlet)
$originalLocation = Get-Location
try {
$systemDrive = ($env:SystemDrive).Replace(":","$")
$testPath = Join-Path "\\localhost" $systemDrive
& $cmdlet $testPath
Get-Location | Should BeExactly "Microsoft.PowerShell.Core\FileSystem::$testPath"
$children = { Get-ChildItem -ErrorAction Stop } | Should Not Throw
$children.Count | Should BeGreaterThan 0
}
finally {
Set-Location $originalLocation
}
}
}