Replace httpbin.org/gzip Tests with WebListener and Re-Enable Deflate Tests #4948
Conversation
markekraus
requested review from
TravisEz13,
adityapatwardhan and
daxian-dbw
as code owners
| } | ||
| } | ||
| # Validate response content | ||
| $result.Output.Headers.'Content-Encoding'[0] | Should Be $dataEncoding |
There was a problem hiding this comment.
Maybe, Should BeExactly?
| # Validate response content | ||
| $result.Output.Headers.'Content-Encoding'[0] | Should Be $dataEncoding | ||
| $jsonContent = $result.Output.Content | ConvertFrom-Json | ||
| $jsonContent.Headers.Host | Should Be $uri.Authority |
| } | ||
| } | ||
| # Validate response content | ||
| $headers.'Content-Encoding'[0] | Should Be $dataEncoding |
| } | ||
| # Validate response content | ||
| $headers.'Content-Encoding'[0] | Should Be $dataEncoding | ||
| $result.Headers.Host | Should Be $uri.Authority |
test/tools/WebListener/README.md
Outdated
| "args": {}, | ||
| "origin": "127.0.0.1", | ||
| "headers": { | ||
| "User-Agent": "Mozilla/5.0 (Windows NT; Windows NT 10.0; en-US) WindowsPowerShell/5.1.15063.608", |
There was a problem hiding this comment.
Should this be PowerShell/6.0.0 instead of WindowsPowerShell?
test/tools/WebListener/README.md
Outdated
| "args": {}, | ||
| "origin": "127.0.0.1", | ||
| "headers": { | ||
| "User-Agent": "Mozilla/5.0 (Windows NT; Windows NT 10.0; en-US) WindowsPowerShell/5.1.15063.608", |
There was a problem hiding this comment.
Should this be PowerShell/6.0.0 instead of WindowsPowerShell?
|
test fails unrelated (#4958) |
|
@markekraus those numbers probably refer to old bugs we used to track internally in TFS, quite possibly no longer relevant |
|
@markekraus The tests seemed to have hanged in Invoke-WebRequest tests. Please have a look. |
|
@adityapatwardhan I'm not sure it is related. https://travis-ci.org/PowerShell/PowerShell/jobs/281240156 had passed and the only changes since were superficial. I think it was a random macOS issue on Travis CI. I've pushed an empty commit to rerun the tests |
|
@adityapatwardhan speaking of unrelated macOS failures in Travis CI https://travis-ci.org/PowerShell/PowerShell/jobs/282354703 :( Does someone have access to restart just that Job? Or should just push another empty commit? |
|
@markekraus I restarted it for you |
|
@SteveL-MSFT Thanks! |
4 participants
Compression/Gziptest to WebListenerCompression/Deflatetest to WebListener-TestCasefromforeachI have no idea what ''7976639:Invoke-WebRequest does not support -TransferEncoding deflate'' and "7976639:Invoke-RestMethod does not support -TransferEncoding deflate" are, but in my limited testing it appears to no longer be true.
reference #2504