Autocorrected CRLF to LF #4943
Merged
Autocorrected CRLF to LF #4943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveL-MSFT
requested review from
TravisEz13,
adityapatwardhan and
daxian-dbw
as code owners
SteveL-MSFT
force-pushed
the
crlf2lf
branch
from
573ccf1 to
59e94e0
Compare
Member
|
Add |
daxian-dbw
approved these changes
Sep 29, 2017
Member
Author
|
@daxian-dbw that's an awesome tip! |
daxian-dbw
reviewed
Sep 29, 2017
Member
There was a problem hiding this comment.
Actually, one question about \r?\n here. Is it because we use CRLF on windows and LF on Unix? If so, can we do the following instead?
$newLine = [System.Environment]::NewLine
$result | should be "${newLine}foo``u\{2195\}abc${newLine}"
Member
Author
There was a problem hiding this comment.
Yes, it is because git converts files to CRLF on Windows. I like your suggestion and will make the change.
SteveL-MSFT
force-pushed
the
crlf2lf
branch
from
59e94e0 to
5a35a4a
Compare
Member
Author
|
@daxian-dbw I'm going to revert that last change, seems that on Windows you might have git set to not convert to CRLF which may be why it's failing on AppVeyor as it was just LF. |
daxian-dbw
approved these changes
Sep 29, 2017
This reverts commit 5a35a4a342581545cc3d22ec608c03d50ccebc85.
SteveL-MSFT
force-pushed
the
crlf2lf
branch
from
b246869 to
ac69b4c
Compare
This was referenced Sep 30, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Parser.Tests.ps1 to use regex: