Replace httpbin.org/delay Tests with WebListener #4905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add TestValue Parameer to accomodate tests which take a value such as Redirect, Encoding and Delay * Adjust existing tests to use TestValue parameter
markekraus
requested review from
TravisEz13,
adityapatwardhan and
daxian-dbw
as code owners
|
@markekraus, |
TravisEz13
approved these changes
Sep 25, 2017
dantraMSFT
reviewed
Sep 25, 2017
| Returns the same results as the Get test. If a number is supplied, the server will wait that many seconds before returning a response. This can be used to test timeouts. | ||
|
|
||
| ```powershell | ||
| Invoke-WebRequest -Uri 'http://localhost:8083/Delay/5' |
Contributor
There was a problem hiding this comment.
Most of the tests are using the Get-WebListenerUrl function. Suggest adding an example for that as well.
$uri = Get-WebListenerUrl -Test 'Delay' -TestValue '5' #Closed
Contributor
Author
There was a problem hiding this comment.
I will add those on the next iteration. Created #4918 to track. (pull was merged before i could update). #Closed
This was referenced Sep 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, there were some odd things coupled with this change that were all somewhat interdependent.
Delaytest to WebListener-TestValueparameter toGet-WebListenerUrlto support tests which take a value such as encoding, redirect, and delay-TestValueI discovered in switching this that the URL's that were being used (e.g.
http://httpbin.org/delay/:5) were actually pointing to a page that immediately returned a505error. The pages were not actually delayed and the web cmdlets were not actually timing out. The tests were passing, but they were checking for the wrong Error ID. I had to correct the error ID in all the tests.Ironically, httpbin.org is having a ton of issues right now. I will push a feature tag later after they have stabilized.Feature tag pushed.reference #2504