Skip to content

Added functionality to set credientials on Set-Service command #4844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 9 commits into from
Sep 18, 2017
Merged

Added functionality to set credientials on Set-Service command #4844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b686ec4
PowerShell/PowerShell#4843 Credentials on Set-Service
joandrsn Sep 15, 2017
58383f4
Clean up
joandrsn Sep 15, 2017
6fe54d4
[Feature]Test added for Set-Service with credentials
joandrsn Sep 15, 2017
f09e87d
[Feature]Test with windows builtin users
joandrsn Sep 15, 2017
d1a02ce
[Feature]Descriptive test in Set-Service with credentials
joandrsn Sep 15, 2017
3bd3376
[Feature]Set-Service with credentials creates users for the test
joandrsn Sep 15, 2017
c08466f
[Feature]Clean Set-Service credential test
joandrsn Sep 15, 2017
e0f2cd8
[Feature]Remove TestCases from Set-Service with credential test
joandrsn Sep 15, 2017
ad1b5dd
[Feature]Remove unnecessary param in Set-Service with credentials test
joandrsn Sep 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 24 additions & 4 deletions src/Microsoft.PowerShell.Commands.Management/commands/management/Service.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1466,6 +1466,14 @@ public class SetServiceCommand : ServiceOperationBaseCommand
}
internal string displayName = null;

/// <summary>
/// Account under which the service should run
/// </summary>
/// <value></value>
[Parameter]
[Credential()]
public PSCredential Credential { get; set; }



/// <summary>
Expand Down Expand Up @@ -1589,6 +1597,7 @@ protected override void ProcessRecord()
{
ServiceController service = null;
string ServiceComputerName = null;
IntPtr password = IntPtr.Zero;
foreach (string computer in ComputerName)
{
bool objServiceShouldBeDisposed = false;
Expand Down Expand Up @@ -1679,9 +1688,9 @@ protected override void ProcessRecord()
continue;
}

// modify startup type or display name
// Modify startup type or display name or credential
if (!String.IsNullOrEmpty(DisplayName)
|| (ServiceStartMode)(-1) != StartupType)
|| (ServiceStartMode)(-1) != StartupType || null != Credential)
{
DWORD dwStartType = NativeMethods.SERVICE_NO_CHANGE;
switch (StartupType)
Expand All @@ -1701,6 +1710,13 @@ protected override void ProcessRecord()
"bad StartupType");
break;
}

string username = null;
if (null != Credential)
{
username = Credential.UserName;
password = Marshal.SecureStringToCoTaskMemUnicode(Credential.Password);
}
bool succeeded = NativeMethods.ChangeServiceConfigW(
hService,
NativeMethods.SERVICE_NO_CHANGE,
Expand All @@ -1710,8 +1726,8 @@ protected override void ProcessRecord()
null,
IntPtr.Zero,
null,
null,
IntPtr.Zero,
username,
password,
DisplayName
);
if (!succeeded)
Expand Down Expand Up @@ -1847,6 +1863,10 @@ protected override void ProcessRecord()
} //End try
finally
{
if (IntPtr.Zero != password)
{
Marshal.ZeroFreeCoTaskMemUnicode(password);
}
if (objServiceShouldBeDisposed)
{
service.Dispose();
Expand Down
33 changes: 33 additions & 0 deletions test/powershell/Modules/Microsoft.PowerShell.Management/Set-Service.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,39 @@ Describe "Set/New-Service cmdlet tests" -Tags "Feature", "RequireAdminOnWindows"
$newServiceCommand.$parameter | Should Be $value
}

It "Set-Service can change credentials of a service" {
try {
$startUsername = "user1"
$endUsername = "user2"
$testPass = "Secret123!"
$servicename = "testsetcredential"
net user $startUsername $testPass /add > $null
net user $endUsername $testPass /add > $null
$password = ConvertTo-SecureString $testPass -AsPlainText -Force
$creds = [pscredential]::new(".\$startUsername", $password)
$parameters = @{
Name = $servicename;
BinaryPathName = "$PSHOME\powershell.exe";
StartupType = "Manual";
Credential = $creds
}
$service = New-Service @parameters
$service | Should Not BeNullOrEmpty
$service = Get-CimInstance Win32_Service -Filter "name='$servicename'"
$service.StartName | Should BeExactly $creds.UserName

$creds = [pscredential]::new(".\$endUsername", $password)
Set-Service -Name $servicename -Credential $creds
$service = Get-CimInstance Win32_Service -Filter "name='$servicename'"
$service.StartName | Should BeExactly $creds.UserName
}
finally {
Get-CimInstance Win32_Service -Filter "name='$servicename'" | Remove-CimInstance -ErrorAction SilentlyContinue
net user $startUsername /delete > $null
net user $endUsername /delete > $null
}
}

It "New-Service can create a new service called '<name>'" -TestCases @(
@{name = "testautomatic"; startupType = "Automatic"; description = "foo" ; displayname = "one"},
@{name = "testmanual" ; startupType = "Manual" ; description = "bar" ; displayname = "two"},
Expand Down