Fix xunnit test for PS #4780

chunqingchen · 2017-09-08T00:22:54Z

Fixes #852 #851
This is to enable xunit test on all platforms.

This fix includes following change:

Change test framework from visualstudio xunit to Dotnet Xunit, now the tests can be run on multiple platforms
Modify any tests that will fail the test build.
Added a function Test-XUnitTestResults for analyze PSxUnit output.
Added fx-version workaround for dotnet xunit
Updated appveyor.ps1 to run Start-PsXunit for daily builds.
Updated travis.ps1 to run Start-PsXunit for daily builds.

markekraus · 2017-09-08T12:35:36Z

build.psm1

This should probably stay before any calls made to dotnet.

JamesWTruher

a couple of the tests aren't testing the thing they purport to test, so they should be fixed or removed.

JamesWTruher · 2017-09-08T16:55:31Z

test/csharp/test_ExtensionMethods.cs

This doesn't seem to be checking the method on the PSTypeExtensions object. Shouldn't this be something like:
Assert.False(PSTypeExtensions.IsNumeric("string".GetType())
It should actually test the PSTypeExtensions object or just removed

JamesWTruher · 2017-09-08T16:58:37Z

test/csharp/test_Binders.cs

see my comment below

JamesWTruher · 2017-09-08T17:01:19Z

test/csharp/test_CorePsPlatform.cs

this isn't very useful and no longer tests what it is reported to test. This needs to check to see that the username returned by whoami is the same as Platform.Unix.UserName. Also, this is a non-windows only test. Is there a way to notate that?

TravisEz13 · 2017-09-19T20:52:33Z

@JamesWTruher Can you update your review?

adityapatwardhan · 2017-09-26T18:09:11Z

build.psm1

How is a failure in xUnit propagated to a failure in AppVeyor / Travis?

JamesWTruher

if everything actually runs on MacOS/Linux ok then I feel it would be better to get it in sooner rather than later. However, Aditya's question needs to be answered, how do we incorporate these results into our pester results?

JamesWTruher · 2017-09-26T23:09:02Z

test/csharp/test_CorePsPlatform.cs

i believe that this is still not good for MacOS. hostname --fqdn is an error. Will this run on Mac?

adityapatwardhan · 2017-10-30T18:10:47Z

@chunqingchen This needs to be open. I am working on it.

adityapatwardhan · 2017-11-28T19:43:49Z

@JamesWTruher @daxian-dbw I have updated the PR with multiple changes list in the PR description. All tests pass in CI and the log file is uploaded to artifacts on AppVeyor. Please have look.

JamesWTruher · 2017-11-28T20:47:31Z

build.psm1

this should probably be throw or something - if $results has a problem then it might look like everything passed since the error will likely be hidden in the log

added throw instead of Write-Error

JamesWTruher · 2017-11-28T20:51:18Z

build.psm1

can this be simplified to just:
if ( -not (test-path (get-psoutput)))

We use $Content later. So I will keep it as is.

JamesWTruher · 2017-11-28T20:56:37Z

test/csharp/test_MshSnapinInfo.cs

does this need a Skip.IfNot(Platform.IsWindows)?

daxian-dbw

Leave some comments

daxian-dbw · 2017-11-30T00:09:29Z

build.psm1

maybe the single quote is not needed ...

daxian-dbw · 2017-11-30T00:13:43Z

build.psm1

maybe move this line closer to its uses.

daxian-dbw · 2017-11-30T00:18:33Z

test/csharp/csharp.tests.csproj

Maybe not needed as it's already included in Tests.Common.props.

daxian-dbw · 2017-11-30T00:18:50Z

test/csharp/csharp.tests.csproj

It's not just Linux now.

daxian-dbw · 2017-11-30T00:21:40Z

test/csharp/csharp.tests.csproj

Please add a comment here

daxian-dbw · 2017-11-30T00:26:28Z

tools/appveyor.psm1

it will write a true or false in console, should be suppressed.

daxian-dbw · 2017-11-30T00:27:20Z

tools/travis.ps1

nit: the ending quote is not needed.

adityapatwardhan · 2017-11-30T01:54:43Z

@daxian-dbw All comments have been addressed and all tests have passed.

adityapatwardhan · 2017-11-30T20:56:30Z

@daxian-dbw is this ready to merge?

* Initial work to enable xunit * Moved AssemblyOriginatorKeyFile to csharp.tests.csproj * Native binary has dylib extension on macOS

chunqingchen requested review from TravisEz13, adityapatwardhan and daxian-dbw as code owners September 8, 2017 00:22

msftclas added the cla-not-required label Sep 8, 2017

chunqingchen force-pushed the xunitTest branch from d0b8a16 to db12347 Compare September 8, 2017 00:26

daxian-dbw requested review from JamesWTruher, SteveL-MSFT and anmenaga September 8, 2017 04:46

markekraus reviewed Sep 8, 2017

View reviewed changes

JamesWTruher suggested changes Sep 8, 2017

View reviewed changes

daxian-dbw assigned adityapatwardhan Sep 8, 2017

chunqingchen force-pushed the xunitTest branch from db12347 to 08d5cde Compare September 19, 2017 00:55

msftgits removed the cla-not-required label Sep 26, 2017

adityapatwardhan requested changes Sep 26, 2017

View reviewed changes

build.psm1 Outdated

Copy link

Member

adityapatwardhan Sep 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is a failure in xUnit propagated to a failure in AppVeyor / Travis?

JamesWTruher reviewed Sep 26, 2017

View reviewed changes

adityapatwardhan force-pushed the xunitTest branch from 08d5cde to fac8815 Compare October 25, 2017 20:54

chunqingchen closed this Oct 30, 2017

adityapatwardhan reopened this Oct 30, 2017

adityapatwardhan force-pushed the xunitTest branch from cd552f4 to 91b85a8 Compare October 30, 2017 23:11

adityapatwardhan force-pushed the xunitTest branch 2 times, most recently from bb3966b to d449465 Compare November 28, 2017 01:08

adityapatwardhan approved these changes Nov 28, 2017

View reviewed changes

adityapatwardhan assigned daxian-dbw and unassigned adityapatwardhan Nov 28, 2017

JamesWTruher reviewed Nov 28, 2017

View reviewed changes

JamesWTruher approved these changes Nov 28, 2017

View reviewed changes

daxian-dbw approved these changes Nov 30, 2017

View reviewed changes

adityapatwardhan added 5 commits November 30, 2017 14:15

Initial work to enable xunit

473a39c

Moved AssemblyOriginatorKeyFile to csharp.tests.csproj

73ac2ca

Native binary has dylib extension on macOS

111b68d

Addressed CR comments

15f68e9

Addressed CR comments

d7b7433

adityapatwardhan force-pushed the xunitTest branch from faa4ee7 to d7b7433 Compare November 30, 2017 22:16

adityapatwardhan merged commit 52df947 into PowerShell:master Nov 30, 2017

TravisEz13 modified the milestone: 6.0.0-GA Dec 1, 2017

daxian-dbw mentioned this pull request Dec 1, 2017

Enable xUnit tests on OS X #851

Closed

TravisEz13 added this to the 6.0.0-RC.2 milestone Dec 2, 2017

TravisEz13 pushed a commit to TravisEz13/PowerShell that referenced this pull request Dec 2, 2017

Fix xunnit test for PS (PowerShell#4780)

1ed5e7f

* Initial work to enable xunit * Moved AssemblyOriginatorKeyFile to csharp.tests.csproj * Native binary has dylib extension on macOS

TravisEz13 mentioned this pull request Dec 2, 2017

Merge 6.0.0 rc.2 changes #5606

Merged

TravisEz13 pushed a commit that referenced this pull request Dec 2, 2017

Fix xunnit test for PS (#4780)

22abe98

* Initial work to enable xunit * Moved AssemblyOriginatorKeyFile to csharp.tests.csproj * Native binary has dylib extension on macOS

Fix xunnit test for PS #4780

Fix xunnit test for PS #4780

Uh oh!

Conversation

chunqingchen commented Sep 8, 2017 • edited by daxian-dbw Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JamesWTruher left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TravisEz13 commented Sep 19, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JamesWTruher left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adityapatwardhan commented Oct 30, 2017

Uh oh!

adityapatwardhan commented Nov 28, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

daxian-dbw left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adityapatwardhan commented Nov 30, 2017

Uh oh!

adityapatwardhan commented Nov 30, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

chunqingchen commented Sep 8, 2017 •

edited by daxian-dbw

Loading