Removed double spaces from .cs and .ps1 files #4743
Conversation
SteveL-MSFT
requested review from
BrucePay,
JamesWTruher,
PaulHigin,
adityapatwardhan,
anmenaga,
charub,
dantraMSFT,
daxian-dbw,
lzybkr,
mirichmo and
vors
as code owners
|
|
||
| var productAttribute = assembly.GetCustomAttribute<AssemblyProductAttribute>(); | ||
| if (productAttribute != null && string.Equals(productAttribute.Product, "Microsoft® .NET Framework", StringComparison.OrdinalIgnoreCase)) | ||
| if (productAttribute != null && string.Equals(productAttribute.Product, "Microsoft� .NET Framework", StringComparison.OrdinalIgnoreCase)) |
There was a problem hiding this comment.
Please revert the change.
| if (result == null) | ||
| { | ||
| result = AutomountBuiltInDrive(name); // internally this calls GetDrive(name, false) | ||
| } |
There was a problem hiding this comment.
I wonder what is changed here? EOL?
There was a problem hiding this comment.
Git gave some warnings about line endings (and performing some LF<->CRLF conversions on my behalf since I was doing this on Windows), so I think that's what this is.
There was a problem hiding this comment.
Thanks for clarify.
Closed.
There was a problem hiding this comment.
The original file had inconsistent line endings, LF everywhere but this region. Your script changed the file to have consistent line endings, so git sees this region differently I guess.
|
|
||
| /// <summary> | ||
| ///Memory Stream used for serialization | ||
| ///Memory Stream used for serialization |
There was a problem hiding this comment.
Please add space before Memory.
It seems we should set final point.
…istent formatting
iSazonov
left a comment
iSazonov
left a comment
There was a problem hiding this comment.
So many files - we need an approvement from someone else.
| if (result == null) | ||
| { | ||
| result = AutomountBuiltInDrive(name); // internally this calls GetDrive(name, false) | ||
| } |
There was a problem hiding this comment.
Thanks for clarify.
Closed.
| const string findViewType = "FINDING VIEW TYPE: {0}"; | ||
| const string findViewType = "FINDING VIEW TYPE: {0}"; | ||
| const string findViewShapeType = "FINDING VIEW {0} TYPE: {1}"; | ||
| const string findViewNameType = "FINDING VIEW NAME: {0} TYPE: {1}"; |
|
|
||
| var productAttribute = assembly.GetCustomAttribute<AssemblyProductAttribute>(); | ||
| if (productAttribute != null && string.Equals(productAttribute.Product, "Microsoft® .NET Framework", StringComparison.OrdinalIgnoreCase)) | ||
| if (productAttribute != null && string.Equals(productAttribute.Product, "Microsoft® .NET Framework", StringComparison.OrdinalIgnoreCase)) |
There was a problem hiding this comment.
Can we change this to Microsoft\u00a9 (assuming that is the correct character). When we run automated tools, they always mess this character up.
There was a problem hiding this comment.
We have the character in some files - maybe fix this all in follow PR?
There was a problem hiding this comment.
Created issue #4752 as we should just fix that (and potentially Trademark as well)
4 participants
Did a regular expression search "\b \b" in VSCode while checking if https://github.com/PowerShell/PowerShell/pull/4741/files missed any, so fixing the ones in .cs and .ps1 files.
A few left in that help align comments making them easier to read.
Removed one commented out code that doesn't provide value.
The file SessionStateDriveAPIs.cs has a section that I didn't change, but git complained it had LF line endings and resaving as CRLF, so maybe only that section had mixed line endings.