Enable cross compiling for raspberry-pi arm32 #4742
Conversation
SteveL-MSFT
requested review from
adityapatwardhan and
daxian-dbw
as code owners
TravisEz13
left a comment
TravisEz13
left a comment
There was a problem hiding this comment.
LGTM @daxian-dbw Can you review?
build.psm1
Outdated
There was a problem hiding this comment.
nit: inconsistent use of braces
build.psm1
Outdated
|
Can we either merge the PR to update build.sh here or remove it. |
tools/packaging/packaging.psm1
Outdated
There was a problem hiding this comment.
Let's not modify $Script:Options. $Script:Options in packaging.psm1 is pointing to the same object holding by $script:Options in build.psm1 which is supposed to reflect the real configuration of the latest build.
I suggest to add one if block below to set crossGenCorrect in case of deb-arm, like
if ($Type -eq "deb-arm") {
$crossGenCorrect = $true
} elseif(-not $IncludeSymbols.IsPresent -and $Script:Options.CrossGen) {
....
} elseif ...
tools/packaging/packaging.psm1
Outdated
There was a problem hiding this comment.
If we don't change $Script:Options, this line should be moved back to its original position.
|
@SteveL-MSFT Please fix merge conflicts |
SteveL-MSFT
force-pushed
the
raspberry-pi
branch
from
5cdfc7f to
21bf93c
Compare
|
@TravisEz13 fixed |
|
@TravisEz13 can you merge? |
4 participants
https://github.com/dotnet/coreclr/issues/13667 prevents this from running correctly, but it builds correctly
Fix #2463