Skip to content

Remove double spaces between words in resx files (#4740) #4741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 1 commit into from
Sep 3, 2017
Merged

Remove double spaces between words in resx files (#4740) #4741

iSazonov merged 1 commit into from
Sep 3, 2017

Conversation

@korygill
Copy link
Contributor

@korygill korygill commented Sep 2, 2017

Fix for issue #4740.

@msftclas
Copy link

msftclas commented Sep 2, 2017

@korygill,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

iSazonov
iSazonov approved these changes Sep 2, 2017
View reviewed changes
Copy link
Collaborator

@iSazonov iSazonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@korygill Thanks for fixing the typos!

markekraus
markekraus approved these changes Sep 2, 2017
View reviewed changes
Copy link
Contributor

@markekraus markekraus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

SteveL-MSFT
SteveL-MSFT approved these changes Sep 2, 2017
View reviewed changes
Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markekraus
Copy link
Contributor

markekraus commented Sep 2, 2017

@SteveL-MSFT Thinking about this further, couldn't some of these possibly be Bucket 2 or 3 breaking changes since they modify errors that some may be relying on?

@SteveL-MSFT
Copy link
Member

SteveL-MSFT commented Sep 3, 2017

@markekraus users should not rely on parsing error messages as they can be localized. the error messages are meant for humans to read. automation should rely on things like the FullyQualifiedErrorId and Exception types.

@markekraus
Copy link
Contributor

markekraus commented Sep 3, 2017

@SteveL-MSFT Thanks! I was pretty sure that would be the answer but wanted to verify.

@iSazonov
Copy link
Collaborator

iSazonov commented Sep 3, 2017

We even have examples of where we changed (removed and added) FullyQualifiedErrorId and Exception types - this was due to error correction or the addition of new features and was therefore not considered an invalid or destructive change.

@iSazonov iSazonov self-assigned this Sep 3, 2017
@iSazonov iSazonov merged commit c14648e into PowerShell:master Sep 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@iSazonov iSazonov iSazonov approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@dantraMSFT dantraMSFT Awaiting requested review from dantraMSFT

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@JamesWTruher JamesWTruher Awaiting requested review from JamesWTruher

@PaulHigin PaulHigin Awaiting requested review from PaulHigin

+1 more reviewer

@markekraus markekraus markekraus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@iSazonov iSazonov

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@korygill @msftclas @markekraus @SteveL-MSFT @iSazonov