Fix 'using module' when module has non-terminating errors handled with 'SilentlyContinue' #4711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h 'SilentlyContinue'
vors
approved these changes
Sep 1, 2017
Member
Author
|
Thanks all for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #4695
Compiler.LoadModuleassumes that whenps.HadErrors == truethe error stream is not empty. However, whenSilentlyContinueis specified as the error action, the non-terminating error is not kept inErrorOutputPipeof the cmdlet and thus does not appear inps.Streams.Error. So whenps.HadErrors == truewhileps.Streams.Erroris empty, it suggests it's OK to ignore the errors because they are explicitly suppressed withSilentlyContinueerror action.So in my opinion, the expected behavior of
"using module .\mod.psm1"in this case should be successful, as ifps.HaddErrorsis false.