Skip to content

Replace extension method 'IsComObject(this Type)' with Type.IsCOMObject #4646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vors merged 1 commit into from
Aug 23, 2017
Merged

Replace extension method 'IsComObject(this Type)' with Type.IsCOMObject #4646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/System.Management.Automation/engine/CoreAdapter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2472,8 +2472,8 @@ internal PropertyCacheEntry(PropertyInfo property)
if (declaringTypeInfo.IsValueType ||
propertyTypeInfo.IsGenericType ||
declaringTypeInfo.IsGenericType ||
property.DeclaringType.IsComObject() ||
property.PropertyType.IsComObject())
property.DeclaringType.IsCOMObject ||
property.PropertyType.IsCOMObject)
{
this.readOnly = property.GetSetMethod() == null;
this.writeOnly = property.GetGetMethod() == null;
Expand Down
2 changes: 1 addition & 1 deletion src/System.Management.Automation/engine/MshObject.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,7 @@ internal static AdapterSet GetMappedAdapter(object obj, TypeTable typeTable)

if (result == null)
{
if (objectType.IsComObject())
if (objectType.IsCOMObject)
{
// All WinRT types are COM types.
// All WinRT types would contain the TypeAttributes flag being set to WindowsRunTime.
Expand Down
10 changes: 0 additions & 10 deletions src/System.Management.Automation/utils/ExtensionMethods.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,16 +118,6 @@ internal static bool IsInteger(this Type type)
return LanguagePrimitives.IsInteger(LanguagePrimitives.GetTypeCode(type));
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
internal static bool IsComObject(this Type type)
{
#if UNIX
return false;
#else
return type.IsCOMObject;
#endif
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
internal static TypeCode GetTypeCode(this Type type)
{
Expand Down