Skip to content

Add more tab completion tests #4560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adityapatwardhan merged 4 commits into from
Aug 15, 2017
Merged

Add more tab completion tests #4560

adityapatwardhan merged 4 commits into from
Aug 15, 2017

Conversation

@daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Aug 11, 2017 •
edited
Loading

The second round of adding tab completion tests - issue: #4160

30 tests are added to improve the test coverage in CompletionAnalysis.cs

CompletionAnalysis.cs

  • cursor position (you have some of these covered, not sure if all)
  • filename after redirection
  • line continuation
  • DSC resource
  • Cursor on special tokens, like comma and minus
  • using module <module-name/file-completion>
  • Enum property value of DSC Resource

adityapatwardhan
adityapatwardhan approved these changes Aug 11, 2017
View reviewed changes
Copy link
Member

@adityapatwardhan adityapatwardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comment.

test/powershell/Host/TabCompletion/TabCompletion.Tests.ps1 Outdated

AfterAll {
Pop-Location
Remove-Item -Path $tempDir -Recurse -Force
Copy link
Member

@adityapatwardhan adityapatwardhan Aug 11, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add -ErrorAction SilentlyContinue

iSazonov
iSazonov reviewed Aug 12, 2017
View reviewed changes
test/powershell/Host/TabCompletion/TabCompletion.Tests.ps1 Outdated
CommandLine = "Test history completion"
ExecutionStatus = "Stopped"
StartExecutionTime = "8/11/2017 11:04:10 AM"
EndExecutionTime = "8/11/2017 11:05:49 AM"
Copy link
Collaborator

@iSazonov iSazonov Aug 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dates is not explicitly used but it is culture dependent. Should our tests work under different cultures?

Copy link
Member

@adityapatwardhan adityapatwardhan Aug 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daxian-dbw Can you address feedback from @iSazonov

Copy link
Member Author

@daxian-dbw daxian-dbw Aug 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Will change to use a DataTime object instead.

@iSazonov
Copy link
Collaborator

iSazonov commented Aug 15, 2017

LGTM.

@adityapatwardhan adityapatwardhan merged commit a648d4d into PowerShell:master Aug 15, 2017
@daxian-dbw daxian-dbw deleted the tabcompletiontest branch August 15, 2017 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@iSazonov iSazonov iSazonov approved these changes

Assignees

@adityapatwardhan adityapatwardhan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@daxian-dbw @iSazonov @adityapatwardhan @msftclas