Skip to content

OpenCover and Code coverage improvements #4550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daxian-dbw merged 1 commit into from
Aug 14, 2017
Merged

OpenCover and Code coverage improvements #4550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions test/tools/CodeCoverageAutomation/Start-CodeCoverageRun.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,12 @@ $jsonFile = "$outputBaseFolder\CC.json"

try
{
## This is required so we do not keep on merging coverage reports.
if(Test-Path $outputLog)
{
Remove-Item $outputLog -Force -ErrorAction SilentlyContinue
}

$oldErrorActionPreference = $ErrorActionPreference
$ErrorActionPreference = 'Stop'
Write-LogPassThru -Message "Starting downloads."
Expand Down Expand Up @@ -264,9 +270,5 @@ finally

## Disable the cleanup till we stabilize.
#Remove-Item -recurse -force -path $outputBaseFolder

## This is required so we do not keep on merging coverage reports.
Remove-Item $outputLog -Force -ErrorAction SilentlyContinue

$ErrorActionPreference = $oldErrorActionPreference
}
2 changes: 1 addition & 1 deletion test/tools/OpenCover/OpenCover.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,7 +555,7 @@ function CreateOpenCoverCmdline($target, $outputLog, $targetArgs)
"-hideskipped:all",
"-mergeoutput",
"-filter:`"+[*]* -[Microsoft.PowerShell.PSReadLine]*`"",
"-targetargs:`"-EncodedCommand $base64targetArgs`""
"-targetargs:`"-NoProfile -EncodedCommand $base64targetArgs`""
Copy link
Collaborator

@JamesWTruher JamesWTruher Aug 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine, and another possible parameter to use is -noninteractive which will keep PSReadLine from being loaded.


$cmdlineAsString = $cmdline -join " "

Expand Down