Skip to content

Conversation

@markekraus
Copy link
Contributor

My Bad... the tests I had in #4479 were failing in the nightly. This fixes them and now they now pass and fail for the right reasons.

@msftclas
Copy link

msftclas commented Aug 6, 2017

@markekraus,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@adityapatwardhan
Copy link
Member

@markekraus Thanks for fixing the tests. Can you run 'Feature' tests to validate that all the required tests are executed.

The documentation for executing additional tests is at: https://github.com/PowerShell/PowerShell/blob/master/docs/testing-guidelines/testing-guidelines.md

Look for the section titled 'Requesting additional tests for a PR'

@adityapatwardhan
Copy link
Member

@markekraus I have pushed an empty commit to execute the feature tests.

@markekraus
Copy link
Contributor Author

@adityapatwardhan Thank you. I will make sure to do this in the future.

@markekraus
Copy link
Contributor Author

markekraus commented Aug 7, 2017

@adityapatwardhan
Copy link
Member

@markekraus Restarted the tests on Travis CI.

@markekraus
Copy link
Contributor Author

@adityapatwardhan
Copy link
Member

@daxian-dbw Can you have a quick look? This fixes the daily build failure.

@adityapatwardhan adityapatwardhan merged commit e4060ab into PowerShell:master Aug 7, 2017
@adityapatwardhan
Copy link
Member

@markekraus Thanks for fixing the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants