Added package reference for 'Microsoft.NETCore.Windows.ApiSets' #4438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxian-dbw
reviewed
Jul 31, 2017
| <PackageReference Include="System.Security.Permissions" Version="4.4.0-preview3-25423-02" /> | ||
| <PackageReference Include="System.Text.Encoding.CodePages" Version="4.4.0-preview3-25423-02" /> | ||
| <PackageReference Include="Microsoft.Management.Infrastructure" Version="1.0.0-alpha*" /> | ||
| <PackageReference Include="Microsoft.NETCore.Windows.ApiSets" Version="1.0.1" /> |
Member
There was a problem hiding this comment.
Please move this reference to the "SDK.csporj". The packages that are not explicitly depended on by projects are put there.
Member
Author
There was a problem hiding this comment.
Fixed. Makes sense.
Member
|
Have you tried if this works on Win7? This package seems to contain nothing and has no dependencies too. |
Member
Author
|
Yes, I have tried it on Win7 SP1. It pulls in more api*.dll binaries with a dotnet publish.
|
daxian-dbw
approved these changes
Jul 31, 2017
Member
Author
|
@mirichmo Can this be merged? This would be a good addition for beta.5. |
Member
|
@adityapatwardhan please resubmit the PR target the release branch. Jason merged a PR that might be risky for the release, so we cannot rebase on master now. |
Member
Author
|
Closing this PR and opening a new one for release branch. |
This was referenced Aug 2, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since .Net Core 2.0, the api sets were moved to a nuget package. Adding a package reference for "Microsoft.NETCore.Windows.ApiSets" gets the required binaries for the Win7 package.
Fixes: #3747