-
Notifications
You must be signed in to change notification settings - Fork 8.1k
add amazonlinux compatibility in install-powershell.sh #4360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add amazonlinux compatibility in install-powershell.sh #4360
Conversation
|
@DarwinJS, |
|
Tested and working on AMI: |
|
It would be good if we have a way of testing this. Do you want to create a docker file with amazonlinux https://hub.docker.com/_/amazonlinux/ which we can use to verify this works during a release? |
|
@TravisEz13 - not sure - the changes were quite moderate - probably just changes needed to support earlier versions of CentOS. Do we test all the other supported distros and versions for the installer? |
|
If you don't think it's needed, please file an issue and mention this PR. It's not much work if the installer is working. Also, Please use the present tense, imperative style for commit messages and title per Contribution Guide |
|
@TravisEz13 - I'm not sure what I should be putting in the issue? This PR is against issue 4359. If you mean that I file one for the docker file - do you mean I ask for one to be made or mention that one is not needed? |
|
@TravisEz13 - I might be interested in doing the docker file. Is there an existing pattern or guidance document? I looked around for docker files in the testing files of the repository - I found one - but can't tell exactly how to wire a new dockerfile into the automated testing. |
|
@DarwinJS Just write a docker file, similar to the ones in https://github.com/PowerShell/PowerShell/tree/master/docker/release and then add it to the list of tests cases here: https://github.com/PowerShell/PowerShell/blob/master/docker/tests/containerTestCommon.psm1#L68 The issue would say that the above needs to be done. |
|
docker file submitted on #4393 |
Amazon linux is a fine mix of CentOS versions ;) Needed to make a few adaptations to get the installer working for it. It might also pickup older versions of CentOS that use /etc/system-release instead of /etc/redhat-release