Skip to content

Fix DeviceGuard data being returned from Get-ComputerInfo and Start-Process test failure #4353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TravisEz13 merged 3 commits into from
Jul 28, 2017
Merged

Fix DeviceGuard data being returned from Get-ComputerInfo and Start-Process test failure #4353

TravisEz13 merged 3 commits into from
Jul 28, 2017

Conversation

@SteveL-MSFT
Copy link
Member

@SteveL-MSFT SteveL-MSFT commented Jul 26, 2017

fix Get-ComputerInfo return of status for DeviceGuard
fix corresponding tests
this is causing one of the failures in our nightly run

@SteveL-MSFT SteveL-MSFT requested a review from jeffbi July 26, 2017 22:08
@SteveL-MSFT
[Feature]
700a1c4 
fix Get-ComputerInfo return of status for DeviceGuard
fix corresponding tests
@SteveL-MSFT SteveL-MSFT force-pushed the deviceguard-startprocess branch from db4d108 to 700a1c4 Compare July 26, 2017 22:08
@jeffbi
Copy link
Contributor

jeffbi commented Jul 26, 2017

LGTM

@SteveL-MSFT SteveL-MSFT force-pushed the deviceguard-startprocess branch from 700a1c4 to c17c4b2 Compare July 27, 2017 05:01
@SteveL-MSFT
Copy link
Member Author

SteveL-MSFT commented Jul 27, 2017

CI failure is on Start-Process which is affecting nightly runs. I'm working on that today.

@SteveL-MSFT
Copy link
Member Author

SteveL-MSFT commented Jul 27, 2017

@jeffbi can you formally approve? thanks!

@SteveL-MSFT SteveL-MSFT force-pushed the deviceguard-startprocess branch 2 times, most recently from 0762758 to ca13a95 Compare July 28, 2017 17:53
@SteveL-MSFT
[Feature]
d78e9ba 
In CI, notepad.exe isn't starting (or starting in time) when using start-process with .txt based on file association.
Since the test is validating opening files by association, fix is to create our own association that is predictable.
@SteveL-MSFT SteveL-MSFT force-pushed the deviceguard-startprocess branch from ca13a95 to d78e9ba Compare July 28, 2017 17:58
@SteveL-MSFT SteveL-MSFT changed the title Fix DeviceGuard data being returned from Get-ComputerInfo Fix DeviceGuard data being returned from Get-ComputerInfo and Start-Process test failure Jul 28, 2017
@SteveL-MSFT
Copy link
Member Author

SteveL-MSFT commented Jul 28, 2017

@TravisEz13 can you review the test change to Start-Process test?

@SteveL-MSFT SteveL-MSFT mentioned this pull request Jul 28, 2017
Merged
@TravisEz13 TravisEz13 merged commit 06d416b into PowerShell:master Jul 28, 2017
@SteveL-MSFT SteveL-MSFT deleted the deviceguard-startprocess branch July 28, 2017 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

+1 more reviewer

@jeffbi jeffbi jeffbi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TravisEz13 TravisEz13

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SteveL-MSFT @jeffbi @TravisEz13 @msftclas