Skip to content

Increase test coverage for Rename-Item and Move-Item #4329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityapatwardhan merged 6 commits into from
Aug 2, 2017
Merged

Increase test coverage for Rename-Item and Move-Item #4329

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f4ea391
Increase test coverage for Rename-Item and Move-Item
Jul 24, 2017
e8d304f
Changes per code review.
Jul 25, 2017
26595b8
Fix typos
Aug 1, 2017
657a494
Add access-denied tests
Aug 1, 2017
ec3b580
Add -skip on Unix for access-denied tests.
Aug 1, 2017
c7240df
Cleanup to fix CI failure.
Aug 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 82 additions & 1 deletion test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,14 +65,54 @@ Describe "Basic FileSystem Provider Tests" -Tags "CI" {
$existsAfter | Should Be $false
}

It "Verify Rename-Item for file" {
Rename-Item -Path $testFile -NewName $newTestFile -ErrorAction Stop
$testFile | Should Not Exist
$newTestFile | Should Exist
}

It "Verify Rename-Item for directory" {
Rename-Item -Path $testDir -NewName $newTestDir -ErrorAction Stop
$testDir | Should Not Exist
$newTestDir | Should Exist
}

It "Verify Rename-Item will not rename to an existing name" {
{ Rename-Item -Path $testFile -NewName $testDir -ErrorAction Stop } | ShouldBeErrorId "RenameItemIOError,Microsoft.PowerShell.Commands.RenameItemCommand"
$Error[0].Exception | Should BeOfType System.IO.IOException
$testFile | Should Exist
}

It "Verify Copy-Item" {
$newFile = Copy-Item -Path $testFile -Destination $newTestFile -PassThru
$fileExists = Test-Path $newTestFile
$fileExists | Should Be $true
$newFile.Name | Should Be $newTestFile
}

It "Verify Move-Item" {
It "Verify Move-Item for file" {
Move-Item -Path $testFile -Destination $testDir -ErrorAction Stop
$testFile | Should Not Exist
"$testDir/$testFile" | Should Exist
}

It "Verify Move-Item for directory" {
$destDir = "DestinationDirectory"
New-Item -Path $destDir -ItemType Directory -ErrorAction Stop >$null
Move-Item -Path $testFile -Destination $testDir
Move-Item -Path $testDir -Destination $destDir
$testDir | Should Not Exist
"$destDir/$testDir" | Should Exist
"$destDir/$testDir/$testFile" | Should Exist
}

It "Verify Move-Item will not move to an existing file" {
{ Move-Item -Path $testDir -Destination $testFile -ErrorAction Stop } | ShouldBeErrorId "MoveDirectoryItemIOError,Microsoft.PowerShell.Commands.MoveItemCommand"
$Error[0].Exception | Should BeOfType System.IO.IOException
$testDir | Should Exist
}

It "Verify Move-Item as substitute for Rename-Item" {
$newFile = Move-Item -Path $testFile -Destination $newTestFile -PassThru
$fileExists = Test-Path $newTestFile
$fileExists | Should Be $true
Expand Down Expand Up @@ -155,6 +195,47 @@ Describe "Basic FileSystem Provider Tests" -Tags "CI" {
}
}

Context "Validate behavior when access is denied" {
BeforeAll {
if ($IsWindows)
{
$powershell = "powershell.exe"
$protectedPath = Join-Path ([environment]::GetFolderPath("windows")) "appcompat" "Programs"
$protectedPath2 = Join-Path $protectedPath "Install"
$newItemPath = Join-Path $protectedPath "foo"
}
$errFile = "error.txt"
$doneFile = "done.txt"
}

AfterEach {
Remove-Item -Force $errFile -ErrorAction SilentlyContinue
Remove-Item -Force $doneFile -ErrorAction SilentlyContinue
}

It "Access-denied test for '<cmdline>" -Skip:(-not $IsWindows) -TestCases @(
@{cmdline = "Get-Item $protectedPath2"; expectedError = "ItemExistsUnauthorizedAccessError,Microsoft.PowerShell.Commands.GetItemCommand"}
@{cmdline = "Get-ChildItem $protectedPath"; expectedError = "DirUnauthorizedAccessError,Microsoft.PowerShell.Commands.GetChildItemCommand"}
@{cmdline = "New-Item -Type File -Path $newItemPath"; expectedError = "NewItemUnauthorizedAccessError,Microsoft.PowerShell.Commands.NewItemCommand"}
@{cmdline = "Rename-Item -Path $protectedPath -NewName bar"; expectedError = "RenameItemIOError,Microsoft.PowerShell.Commands.RenameItemCommand"},
@{cmdline = "Move-Item -Path $protectedPath -Destination bar"; expectedError = "MoveDirectoryItemIOError,Microsoft.PowerShell.Commands.MoveItemCommand"},
@{cmdline = "Remove-Item -Path $protectedPath"; expectedError = "RemoveItemUnauthorizedAccessError,Microsoft.PowerShell.Commands.RemoveItemCommand"}
) {
param ($cmdline, $expectedError)

runas.exe /trustlevel:0x20000 "$powershell -nop -c try { $cmdline -ErrorAction Stop } catch { `$_.FullyQualifiedErrorId | Out-File $errFile }; New-Item -Type File -Path $doneFile"
$startTime = Get-Date
while (((Get-Date) - $startTime).TotalSeconds -lt 5 -and -not (Test-Path $doneFile))
{
Start-Sleep -Milliseconds 100
}

$errFile | Should Exist
$err = Get-Content $errFile
$err | Should Be $expectedError
}
}

Context "Validate basic host navigation functionality" {
BeforeAll {
#build semi-complex directory structure to test navigation within
Expand Down