Increase test coverage for Rename-Item and Move-Item #4329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantraMSFT
suggested changes
Jul 25, 2017
Contributor
dantraMSFT
left a comment
dantraMSFT
left a comment
There was a problem hiding this comment.
Suggest using -ErrorAction Stop for the operations that you expect to succeed. It will be clearer than diagnosing why the Should statement failed.
Contributor
Author
|
Fixed. |
dantraMSFT
approved these changes
Jul 25, 2017
adityapatwardhan
requested changes
Jul 28, 2017
| "$destDir/$testDir/$testFile" | Should Exist | ||
| } | ||
|
|
||
| It "Verity Move-Item will not move to an existing file" { |
Member
There was a problem hiding this comment.
Typo in Verity -> Verify
SteveL-MSFT
requested changes
Jul 28, 2017
| $testDir | Should Exist | ||
| } | ||
|
|
||
| It "Verify Move-Item as substitue for Rename-Item" { |
Member
|
Add test for |
Contributor
Author
|
Added tests for access-denied. @SteveL-MSFT thanks for the pointer. |
adityapatwardhan
approved these changes
Aug 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses parts of #4148.