Skip to content

Fix regressions that cause implicit remoting tests to fail #4326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
daxian-dbw merged 1 commit into from
Jul 24, 2017
Merged

Fix regressions that cause implicit remoting tests to fail #4326

daxian-dbw merged 1 commit into from
Jul 24, 2017

Conversation

@daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Jul 24, 2017

Three implicit remoting tests failed in daily test runs. They reflect regressions introduced in #4261, and this PR is to fix them.

The original test for those 3 are checking -ne $null | Should Be $true:

## BadVerb-Variable should be a function, not an alias (1)
((Get-Item Function:\BadVerb-Variable -ErrorAction SilentlyContinue) -ne $null) | Should Be $true
...
## BadVerb-Variable should be a function, not an alias (1)
((Get-Item Function:\BadVerb-Variable -ErrorAction SilentlyContinue) -ne $null) | Should Be $true
...
## BadVerb-Variable should be an alias, not a function (2)
((Get-Item Alias:\BadVerb-Variable -ErrorAction SilentlyContinue) -ne $null) | Should Be $true

So we should change them to | Should Not Be $null.

@daxian-dbw daxian-dbw requested a review from iSazonov July 24, 2017 03:45
@daxian-dbw daxian-dbw self-assigned this Jul 24, 2017
@daxian-dbw daxian-dbw mentioned this pull request Jul 24, 2017
Merged
@daxian-dbw
Copy link
Member Author

daxian-dbw commented Jul 24, 2017

The failure in AppVeyor will be resolved by #4323

iSazonov
iSazonov reviewed Jul 24, 2017
View reviewed changes
Copy link
Collaborator

@iSazonov iSazonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@daxian-dbw daxian-dbw merged commit 905e697 into PowerShell:master Jul 24, 2017
@daxian-dbw daxian-dbw deleted the test branch July 24, 2017 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov left review comments

Assignees

@daxian-dbw daxian-dbw

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@daxian-dbw @iSazonov @msftclas