Skip to content

Due to the use of unsupported APIs, we must remove the LocalAccounts module until a better solution is found. #4302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TravisEz13 merged 6 commits into from
Jul 20, 2017
Merged

Due to the use of unsupported APIs, we must remove the LocalAccounts module until a better solution is found. #4302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
324c047
remove references to localaccount in opencover
TravisEz13 Jun 25, 2017
fe24900
move module to full
TravisEz13 Jul 17, 2017
fc01838
remove local accounts updatable help tests
TravisEz13 Jul 17, 2017
ad33306
remove local account from BOM tests
TravisEz13 Jul 17, 2017
88d95e0
disable local account tests
TravisEz13 Jul 17, 2017
3ee44df
remove local accounts from the build [Feature]-2
TravisEz13 Jul 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion build.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2961,7 +2961,6 @@ function Start-CrossGen {
$psCoreAssemblyList += @(
"Microsoft.WSMan.Management.dll",
"Microsoft.WSMan.Runtime.dll",
"Microsoft.PowerShell.LocalAccounts.dll",
"Microsoft.PowerShell.Commands.Diagnostics.dll",
"Microsoft.Management.Infrastructure.CimCmdlets.dll"
)
Expand Down
0 ...LocalAccounts/LocalAccounts.format.ps1xml → ...LocalAccounts/LocalAccounts.format.ps1xml
View file
Open in desktop
File renamed without changes.
0 ...s/Microsoft.PowerShell.LocalAccounts.psd1 → ...s/Microsoft.PowerShell.LocalAccounts.psd1
View file
Open in desktop
File renamed without changes.
1 change: 0 additions & 1 deletion src/powershell-win-core/powershell-win-core.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
<ProjectReference Include="..\Microsoft.PowerShell.SDK\Microsoft.PowerShell.SDK.csproj" />
<ProjectReference Include="..\Microsoft.PowerShell.PSReadLine\Microsoft.PowerShell.PSReadLine.csproj" />
<ProjectReference Include="..\Microsoft.PowerShell.Commands.Diagnostics\Microsoft.PowerShell.Commands.Diagnostics.csproj" />
<ProjectReference Include="..\Microsoft.PowerShell.LocalAccounts\Microsoft.PowerShell.LocalAccounts.csproj" />
<ProjectReference Include="..\Microsoft.Management.Infrastructure.CimCmdlets\Microsoft.Management.Infrastructure.CimCmdlets.csproj" />
<ProjectReference Include="..\Microsoft.WSMan.Management\Microsoft.WSMan.Management.csproj" />
</ItemGroup>
Expand Down
3 changes: 3 additions & 0 deletions test/fullclr/PowerShellGithubDev.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ try
# this Describe makes sure we binplace all the files, like psd1, psm1, ps1xml and load usable modules from them
Describe 'Modules for the package' {
Context '$env:DEVPATH Modules loading' {
<#
removed due to #4272
It 'loads Microsoft.PowerShell.LocalAccounts' {
try
{
Expand All @@ -59,6 +61,7 @@ try
Remove-Module -ErrorAction SilentlyContinue Microsoft.PowerShell.LocalAccounts
}
}
#>

It 'loads Microsoft.PowerShell.Archive' {
try
Expand Down
5 changes: 5 additions & 0 deletions ...rosoft.PowerShell.LocalAccounts/Pester.Command.Cmdlets.LocalAccounts.LocalGroup.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@
#
# Copyright (c) Microsoft Corporation, 2015

# Module removed due to #4272
# disabling tests

return

function RemoveTestGroups
{
param([string] $basename)
Expand Down
5 changes: 5 additions & 0 deletions ....PowerShell.LocalAccounts/Pester.Command.Cmdlets.LocalAccounts.LocalGroupMember.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@
#
# Copyright (c) Microsoft Corporation, 2015

# Module removed due to #4272
# disabling tests

return

function IsWin10OrHigher
{
$version = [system.environment]::osversion.version
Expand Down
5 changes: 5 additions & 0 deletions ...crosoft.PowerShell.LocalAccounts/Pester.Command.Cmdlets.LocalAccounts.LocalUser.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@
#
# Copyright (c) Microsoft Corporation, 2015

# Module removed due to #4272
# disabling tests

return

Set-Variable dateInFuture -option Constant -value "12/12/2036 09:00"
Set-Variable dateInPast -option Constant -value "12/12/2010 09:00"
Set-Variable dateInvalid -option Constant -value "12/12/2016 25:00"
Expand Down
2 changes: 1 addition & 1 deletion test/powershell/engine/Help/UpdatableHelpSystem.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ $powershellCoreModules = @(
"Microsoft.PowerShell.Core"
"Microsoft.PowerShell.Diagnostics"
"Microsoft.PowerShell.Management"
"Microsoft.PowerShell.LocalAccounts"
# "Microsoft.PowerShell.LocalAccounts" removed due to #4274
"Microsoft.PowerShell.Security"
"Microsoft.PowerShell.Utility"
"Microsoft.WsMan.Management"
Expand Down
3 changes: 0 additions & 3 deletions test/tools/OpenCover/OpenCover.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,6 @@ function Expand-ZipArchive([string] $Path, [string] $DestinationPath)
Microsoft.PowerShell.PackageManagement 59.77 62.04 Branch:59.77 Sequence:62.04
Microsoft.PackageManagement 41.73 44.47 Branch:41.73 Sequence:44.47
Microsoft.Management.Infrastructure.CimCmdlets 13.20 17.01 Branch:13.20 Sequence:17.01
Microsoft.PowerShell.LocalAccounts 73.15 84.32 Branch:73.15 Sequence:84.32
Microsoft.PackageManagement.MetaProvider.PowerShell 54.79 57.90 Branch:54.79 Sequence:57.90
Microsoft.PackageManagement.NuGetProvider 62.36 65.37 Branch:62.36 Sequence:65.37
Microsoft.PackageManagement.CoreProviders 7.08 7.96 Branch:7.08 Sequence:7.96
Expand Down Expand Up @@ -285,7 +284,6 @@ function Get-CodeCoverage
Microsoft.PowerShell.ConsoleHost 36.53 0 38.40 0
Microsoft.PowerShell.CoreCLR.AssemblyLoadContext 53.66 0 95.31 0
Microsoft.PowerShell.CoreCLR.Eventing 28.70 0 36.23 0
Microsoft.PowerShell.LocalAccounts 73.15 0 84.32 0
Microsoft.PowerShell.PackageManagement 59.77 0 62.04 0
Microsoft.PowerShell.PSReadLine 7.12 0 9.94 0
Microsoft.PowerShell.Security 15.17 0 18.16 0
Expand All @@ -312,7 +310,6 @@ function Get-CodeCoverage
Microsoft.PowerShell.ConsoleHost 36.53 0 38.40 0
Microsoft.PowerShell.CoreCLR.AssemblyLoadContext 53.66 0 95.31 0
Microsoft.PowerShell.CoreCLR.Eventing 28.70 0 36.23 0
Microsoft.PowerShell.LocalAccounts 73.15 0 84.32 0
Microsoft.PowerShell.PackageManagement 59.77 0 62.04 0
Microsoft.PowerShell.PSReadLine 7.12 0 9.94 0
Microsoft.PowerShell.Security 15.17 0 18.16 0
Expand Down