Skip to content

Conversation

@mirichmo
Copy link
Member

@mirichmo mirichmo commented Jul 17, 2017

This replaces abandoned PR #2184 since the fix looks like it might be worthwhile to include. This PR adds the changes requested in the original PR that held it up from being merged.

PR #2241 included the original tests.

FYI: @TimCurwick

@JamesWTruher
Copy link
Collaborator

LGTM

@mirichmo mirichmo force-pushed the pr-completion-for-convertto-html branch from 4cc8346 to 943eabd Compare July 18, 2017 20:27
@mirichmo
Copy link
Member Author

The content is the same. I just re-did the commit giving @TimCurwick credit for it.

Copy link
Member

@adityapatwardhan adityapatwardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mirichmo
Copy link
Member Author

@PowerShell/powershell-maintainers This is ready for merge

@daxian-dbw daxian-dbw merged commit 4f13bf4 into PowerShell:master Jul 18, 2017
@mirichmo mirichmo deleted the pr-completion-for-convertto-html branch August 8, 2017 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants