add newline at end of file

resolved

delete this empty line

resolved

this is redundant from line 1329

resolved

if we were given a filepath and it doesn't exist, it doesn't seem like we should try to load something that happens to have the same name but different path

resolved

if we were given a filepath and it doesn't exist, it doesn't seem like we should try to load something that happens to have the same name but different path

resolved

We are removing FullCLR code, so you should remove this since you're touching this file

resolved

be consistent with line 1338 and return loadedAssembly on line 1375

resolved

since the FullCLR code should be removed fixedName is only used within this if statement so move it inside the if statement

resolved

if you didn't successfully load the assembly, loadedAssembly should still be null, so I think you can get rid of the return null; statements and just return loadedAssembly at the end

resolved.

make this else if

resolved

Delete blank line

resolved

This works only because the actual assembly name of the assembly generated from Add-Type is not the same as the file name.

Instead of this, you can use Import-Module -Passthru and have the exact Assembly instance to validate.

We also want to avoid Should Be $true because the logs are less useful, so I'd like to see something like:

$assem = Import-Module -PassThru ...
$assem.Location | Should Be $Path

resolved

You should make this a complete cmdlet that can be called. That is the real scenario that needs to be tested.

Are you sure this test validates the fix? It passes even without your fix.

previously when system.automation.management is used loading error will be occured.
Now we have to check the actual cmdlet is loaded.
Resolved.

Once the dll loaded, you will get errors when Pester tries to remove $TestDrive. I suggest you do import-module, $module.Path and Test-BinaryModuleCmdlet1 in a new powershell instance, and use the returned value for validation, so that there won't be any errors when Pester removes $TestDrive.

Plus, Import-Module -PassThru returns a PSModuleInfo object, so the value name should be $module instead of $assembly.

I think your actual intent is to use $module.ImplementingAssembly.Location.

Sorry that maybe I wasn't clear on my comment. I suggest you use powershell.exe to gather the information you want to test. In that way, the generated system.dll won't be loaded into the current app domain and thus Pester can remove it properly later.

It should be something like this:

$results = powershell -noprofile -c "`$module = Import-Module $TESTDRIVE\System.dll -Pssthru; `$module.ImplementingAssembly.Location; Test-BinaryModuleCmdlet1"
$results[0] | Should Be $path
$results[1] | Should BeExactly "BinaryModuleCmdlet1 exported by the ModuleCmdlets module."