Skip to content

Close FileStream opened to read file go get hash. #4175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lzybkr merged 1 commit into from
Jul 7, 2017
Merged

Close FileStream opened to read file go get hash. #4175

lzybkr merged 1 commit into from
Jul 7, 2017

Conversation

@rkeithhill
Copy link
Collaborator

@rkeithhill rkeithhill commented Jul 2, 2017

Fix #4174

@rkeithhill rkeithhill mentioned this pull request Jul 2, 2017
Closed
SteveL-MSFT
SteveL-MSFT reviewed Jul 2, 2017
View reviewed changes
src/Microsoft.PowerShell.Commands.Utility/commands/utility/GetHash.cs
try
{
Stream openfilestream = File.OpenRead(path);
openfilestream = File.OpenRead(path);
Copy link
Member

@SteveL-MSFT SteveL-MSFT Jul 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about 'using' instead?

@rkeithhill
Copy link
Collaborator Author

rkeithhill commented Jul 2, 2017 •
edited
Loading

I went with that approach first but with the catch statement it seemed to read better with try/catch/finally than try {using()} / catch. That said, I can certainly remove the finally and put a using statement inside the try. It's about six of one / half dozen the other. :-)

@iSazonov
Copy link
Collaborator

iSazonov commented Jul 3, 2017

LGTM.

@SteveL-MSFT
Copy link
Member

SteveL-MSFT commented Jul 3, 2017

@rkeithhill looking at the entire file, keeping it try...finally is probably more consistent with other try...catch usage in this file, so LGTM

@rkeithhill
Copy link
Collaborator Author

rkeithhill commented Jul 5, 2017

Sure would be nice to get this fix into beta.4. Got some Plaster users on Linux who are hitting this bug.

@lzybkr lzybkr merged commit fa02e84 into PowerShell:master Jul 7, 2017
@rkeithhill rkeithhill deleted the rkeithhill/fix-get-filehash-open-handle branch May 29, 2019 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

Assignees

@TravisEz13 TravisEz13

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rkeithhill @iSazonov @SteveL-MSFT @lzybkr @msftclas @TravisEz13