Redefine the unicode output condition for nanoserver for "more" function #4074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunqingchen
changed the title
daxian-dbw
reviewed
Jun 23, 2017
Member
There was a problem hiding this comment.
There is no such variable $IsNanoServer in powershell core.
You need to look at [System.Management.Automation.Platform]::IsIoT and [System.Management.Automation.Platform]::IsNanoServer
Member
|
I still would like to have a test for this fix. If it's really impossible, can you please at least have a screenshot to show the behavior difference before and after the fix? |
Contributor
Author
|
Before the fix: After the fix: |
Contributor
Author
|
@daxian-dbw thanks! the comment has been resolved and the screenshots are attached. |
daxian-dbw
reviewed
Jul 25, 2017
Member
There was a problem hiding this comment.
You also need to check [System.Management.Automation.Platform]::IsIoT. IoT is very similar to NanoServer.
Contributor
Author
|
@daxian-dbw resolved |
daxian-dbw
approved these changes
Aug 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #2909
I haven't included a test case with this fix because
Thus, one time manual verification might be enough.
Summary of the issue:
Under non-english OS, if user start ps core under comandline and type "help ", the output will be one character per line
Root cause of the issue:
Only Nano needs to use Unicode, but Windows and Linux need the default encoding. The way we judge if the current os is Nano server has been outdated.
Fix:
Update the condition we use to judge nano server.