Enable Send-MailMessage on CoreCLR #3869
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,147 @@ | ||
| Describe "Basic Send-MailMessage tests" -Tags CI { | ||
| BeforeAll { | ||
| function test-smtpserver | ||
| { | ||
| $rv = $false | ||
|
|
||
| try | ||
| { | ||
| $tc = New-Object -TypeName System.Net.Sockets.TcpClient -ArgumentList "localhost", 25 | ||
| $rv = $tc.Connected | ||
| $tc.Close() | ||
| } | ||
| catch | ||
| { | ||
| $rv = false | ||
| } | ||
|
|
||
| return $rv | ||
| } | ||
|
|
||
| function read-mail | ||
| { | ||
| Param( | ||
| [parameter(Mandatory=$true)] | ||
| [String] | ||
| $mailBox | ||
| ) | ||
|
|
||
| $state = "init" | ||
| $mail = Get-Content $mailBox | ||
| $rv = @{} | ||
| foreach ($line in $mail) | ||
| { | ||
| switch ($state) | ||
| { | ||
| "init" | ||
| { | ||
| if ($line.Length -gt 0) | ||
| { | ||
| $state = "headers" | ||
| } | ||
| } | ||
| "headers" | ||
| { | ||
| if ($line.StartsWith("From: ")) | ||
| { | ||
| $rv.From = $line.Substring(6) | ||
| } | ||
| elseif ($line.StartsWith("To: ")) | ||
| { | ||
| if ($rv.To -eq $null) | ||
| { | ||
| $rv.To = @() | ||
| } | ||
|
|
||
| $rv.To += $line.Substring(4) | ||
| } | ||
| elseif ($line.StartsWith("Subject: ")) | ||
| { | ||
| $rv.Subject = $line.Substring(9); | ||
| } | ||
| elseif ($line.Length -eq 0) | ||
| { | ||
| $state = "body" | ||
| } | ||
| } | ||
| "body" | ||
| { | ||
| if ($line.Length -eq 0) | ||
| { | ||
| $state = "done" | ||
| continue | ||
| } | ||
|
|
||
| if ($rv.Body -eq $null) | ||
| { | ||
| $rv.Body = @() | ||
| } | ||
|
|
||
| $rv.Body += $line | ||
| } | ||
| } | ||
| } | ||
|
|
||
| return $rv | ||
| } | ||
|
|
||
| $PesterArgs = @{ Name = "Can send mail message from user to self"} | ||
| $alreadyHasMail = $true | ||
|
|
||
| if (-not $IsLinux) | ||
| { | ||
| $PesterArgs["Skip"] = $true | ||
| $PesterArgs["Name"] += " (skipped: not Linux)" | ||
| return | ||
| } | ||
|
|
||
| $domain = [Environment]::MachineName | ||
| if (-not (test-smtpserver)) | ||
| { | ||
| $PesterArgs["Pending"] = $true | ||
| $PesterArgs["Name"] += " (pending: no mail server detected)" | ||
| return | ||
| } | ||
|
|
||
| $user = [Environment]::UserName | ||
| $inPassword = Select-String "^${user}:" /etc/passwd -ErrorAction SilentlyContinue | ||
| if (-not $inPassword) | ||
| { | ||
| $PesterArgs["Pending"] = $true | ||
| $PesterArgs["Name"] += " (pending: user not in /etc/passwd)" | ||
| return | ||
| } | ||
|
|
||
| $address = "$user@$domain" | ||
| $mailStore = "/var/mail" | ||
| $mailBox = Join-Path $mailStore $user | ||
| $mailBoxFile = Get-Item $mailBox -ErrorAction SilentlyContinue | ||
| if ($mailBoxFile -ne $null -and $mailBoxFile.Length -gt 2) | ||
| { | ||
| $PesterArgs["Pending"] = $true | ||
| $PesterArgs["Name"] += " (pending: mailbox not empty)" | ||
| return | ||
| } | ||
| $alreadyHasMail = $false | ||
|
Member
There was a problem hiding this comment. I don't understand this, you set
Contributor
Author
There was a problem hiding this comment. This is one of those steps to avoid deleting an existing mailbox. In the |
||
| } | ||
| AfterAll { | ||
| if (-not $alreadyHasMail) | ||
| { | ||
| Set-Content -Value "" -Path $mailBox -Force -ErrorAction SilentlyContinue | ||
|
Collaborator
There was a problem hiding this comment. should this just be delete the file?
Contributor
Author
There was a problem hiding this comment. Unless we're running as root or as a member of the |
||
| } | ||
| } | ||
|
|
||
| It @PesterArgs { | ||
| $body = "Greetings from me." | ||
| $subject = "Test message" | ||
|
Member
There was a problem hiding this comment. shouldn't you also validate the subject? |
||
| Send-MailMessage -To $address -From $address -Subject $subject -Body $body -SmtpServer 127.0.0.1 | ||
|
Collaborator
There was a problem hiding this comment. one more check needed above to be sure that there's an smtp server running on localhost |
||
| Test-Path -Path $mailBox | Should Be $true | ||
| $mail = read-mail $mailBox | ||
| $mail.From | Should BeExactly $address | ||
| $mail.To.Count | Should BeExactly 1 | ||
| $mail.To[0] | Should BeExactly $address | ||
| $mail.Subject | Should BeExactly $subject | ||
| $mail.Body.Count | Should BeExactly 1 | ||
| $mail.Body[0] | Should BeExactly $body | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this test require Administrator on Windows or root on all non-Windows platforms?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently this test runs only on Linux. So long as the sender/receiver of the email is the currently logged-in user, running as root is not required.
I've been looking into ways to make tests more cross-platform, using a suggestion from @iSazonov, but it's going to take some effort.
My personal feeling is that I'd like to create a separate issue for testing
Send-MailMessageand have this PR be taken as-is, but I don't know if that works with testing policies.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeffbi create a separate issue for that and link it to this