Add Homebrew to install docs #3838
Conversation
joeyaiello
requested review from
BrucePay,
HemantMahawar,
JamesWTruher and
SteveL-MSFT
joeyaiello
added
the
Area-Maintainers-Documentation
docs/installation/linux.md
Outdated
There was a problem hiding this comment.
i needed to do brew cask uninstall powershell
docs/installation/linux.md
Outdated
There was a problem hiding this comment.
i don't think these are right - they're not working for me. I get an error message:
brew upgrade powershell
Error: No available formula with the name "powershell"
There was a problem hiding this comment.
How about brew cask upgrade powershell?
There was a problem hiding this comment.
brew cask reinstall powershell
There was a problem hiding this comment.
Wait, reinstall is the upgrade command?
There was a problem hiding this comment.
@joeyaiello For now at least, see Homebrew/homebrew-cask#29301
There was a problem hiding this comment.
Oh, interesting...thanks for the pointer. Looks like that's the way to go now. I'm updating the docs accordingly.
docs/installation/linux.md
Outdated
There was a problem hiding this comment.
This line is installation instruction for cask.
It's not clear from the comment that these two lines correspond to two steps above.
I'd break it down into two parts.
docs/installation/linux.md
Outdated
There was a problem hiding this comment.
Maybe If you PowerShell installed with Homebrew ? Not an English expert, but this language feels too playful :)
There was a problem hiding this comment.
Hahahaha, I just accidentally a word.
docs/installation/linux.md
Outdated
There was a problem hiding this comment.
This is auto-included in powershell brew formula (it's a dependency I think)
Worth pointing out here that it's not required as a separate step with brew.
|
@joeyaiello Don't forget about this one |
|
@mirichmo I hadn't! I just didn't realize anyone had responded yet. It's hard for me to get this one right because I don't actually have a Mac.... |
|
@vors - Are all your concerns addressed? |
|
@mirichmo sorry, this is on me. I've been meaning to grab the Macbook from @daxian-dbw, gotta do my validation real quick. |
|
Okay, sorry for taking so long on this. @mirichmo: it should be good to go now. I validated all the instructions on a Macbook. :) |
|
@vors Do you have any additional comments or concerns? |
|
FWIW, followed these instructions on macOS 10.12.5 with homebrew and cask and it worked for me |
7 participants
Fixes #1779
It would be awesome if someone who actually has a Mac (like @JamesWTruher or @BrucePay) can validate these instructions before we merge them.
Also, it would be great to know how accurate these directions currently are. The reference to .NET Core 1.0.0 makes me think it might be a little outdated.