Part 2 - Improve ValidateCount attribute error message #3656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leave only two message for: 1. Count is not in allowed range. 2. Count is not exactly equal allowed value.
Collaborator
Author
|
Mac build temporary failed. |
mklement0
reviewed
Apr 27, 2017
| throw new ValidationMetadataException("ValidateCountSmallerThanMin", | ||
| null, Metadata.ValidateCountFailure, | ||
| MinLength, MaxLength, len); | ||
| throw new ValidationMetadataException("ValidateCountExactlyFailure", |
Contributor
There was a problem hiding this comment.
LGTM overall, but I suggest removing the "ly": ValidateCountExactlyFailure -> ValidateCountExactFailure
iSazonov
force-pushed
the
validatecount-message2
branch
from
1583c3b to
bdd53bf
Compare
lzybkr
approved these changes
Apr 30, 2017
Member
|
@lzybkr the FullyQualifiedErrorId changed with this PR, does it need to be reviewed by powershell committee as a breaking change? |
Contributor
|
We should document the change, but it's an unlikely breaking change - changing the exception type would be worth discussing, but in this specific case, the error id isn't very interesting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussion #3596 (comment)
Leave only two message for:
/cc @lzybkr @mklement0