Skip to content

Use IntPtr(-1) for INVALID_HANDLE_VALUE instead of IntPtr.Zero #3544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daxian-dbw merged 1 commit into from
Apr 14, 2017
Merged

Use IntPtr(-1) for INVALID_HANDLE_VALUE instead of IntPtr.Zero #3544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/Microsoft.PowerShell.Commands.Management/commands/management/Process.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2608,7 +2608,6 @@ internal struct JOBOBJECT_BASIC_PROCESS_ID_LIST
internal static class ProcessNativeMethods
{
// Fields
internal static readonly IntPtr INVALID_HANDLE_VALUE = IntPtr.Zero;
internal static UInt32 GENERIC_READ = 0x80000000;
internal static UInt32 GENERIC_WRITE = 0x40000000;
internal static UInt32 FILE_ATTRIBUTE_NORMAL = 0x80000000;
Expand Down
2 changes: 1 addition & 1 deletion src/System.Management.Automation/utils/PlatformInvokes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,7 @@ internal struct PRIVILEGE_SET
#if !UNIX

// Fields
internal static readonly IntPtr INVALID_HANDLE_VALUE = IntPtr.Zero;
internal static readonly IntPtr INVALID_HANDLE_VALUE = new IntPtr(-1);
internal static UInt32 GENERIC_READ = 0x80000000;
internal static UInt32 GENERIC_WRITE = 0x40000000;
internal static UInt32 FILE_ATTRIBUTE_NORMAL = 0x80000000;
Expand Down
7 changes: 1 addition & 6 deletions src/powershell-native/nativemsh/pwrshexe/MainEntry.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1139,11 +1139,6 @@ BOOL IsWow64()
{
HANDLE hCurrentProc = GetCurrentProcess();

if (INVALID_HANDLE_VALUE == hCurrentProc)
{
return false;
}

BOOL isWow64Process = FALSE;
BOOL ret = IsWow64Process(hCurrentProc, &isWow64Process);

Expand All @@ -1152,7 +1147,7 @@ BOOL IsWow64()
return isWow64Process;
}

return false;
return FALSE;
}

/**********************************************************************
Expand Down