Add entry points to the windows docker files #3462
Conversation
docker/release/nanoserver/Dockerfile
Outdated
| # Persist %PSCORE% ENV variable for user convenience | ||
| ENV PSCORE='"C:\Program Files\PowerShell\Core\PowerShell.exe"' | ||
|
|
||
| ENTRYPOINT ["cmd", "/c", "\"%PSCORE%\""] |
There was a problem hiding this comment.
You can't just call powershell.exe directly?
docker/release/nanoserver/Dockerfile
Outdated
| # Persist %PSCORE% ENV variable for user convenience | ||
| ENV PSCORE='"C:\Program Files\PowerShell\Core\PowerShell.exe"' | ||
|
|
||
| ENTRYPOINT ["C:\\Program Files\\PowerShell\\Core\\PowerShell.exe"] |
There was a problem hiding this comment.
Typically, powershell.exe is expected to be installed to a versioned folder (c:\program files\powershell\6.0.0-alpha.17\powershell.exe), how does Core fit into this?
There was a problem hiding this comment.
The docker image creates the core folder as a symbolic link (see line 35). This allow this static path to be used.
There was a problem hiding this comment.
Can we rename core to latest?
| @@ -1,5 +1,5 @@ | |||
| # escape=` | |||
| FROM microsoft/windowsservercore | |||
| FROM microsoft/windowsservercore:latest | |||
There was a problem hiding this comment.
How come you don't have this suffix for nanoserver?
There was a problem hiding this comment.
I didn't mean to add it, but it should be there. I'll add it too.
| # escape=` | ||
| FROM microsoft/nanoserver | ||
| FROM microsoft/nanoserver:latest | ||
| MAINTAINER brycem@microsoft.com |
There was a problem hiding this comment.
Should we change this to powershellteam@hotmail.com?
There was a problem hiding this comment.
Does that go anywhere? All the rest have actual email addresses on them. If we want to update them, that should probably be a separate item. The MAINTAINER tag is deprecated anyway. I filed #3465 for this. Can we continue this discussion there?
4 participants
Related to #2793