-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Out-Default incorrectly staying in transcript state #3392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f9dd4f7
Out-Default was incorrectly caching transcription state as the subseq…
SteveL-MSFT 74d92eb
only restore Host.UI.TranscribeOnly if state had changed
SteveL-MSFT 0ae56b6
added addtional test for normal use case for out-default -transcript
SteveL-MSFT e3c05ed
removed unnecessary IDisposable as FrontEndCommandBase already inherits
SteveL-MSFT a2069d6
Changed TranscribeOnly member to a count rather than a bool so nested…
SteveL-MSFT 4f509a3
added test case where garbage collection happens
SteveL-MSFT File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 changes: 39 additions & 0 deletions
39
test/powershell/Modules/Microsoft.PowerShell.Core/Out-Default.Tests.ps1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| Describe "Out-Default Tests" -tag CI { | ||
| BeforeAll { | ||
| # due to https://github.com/PowerShell/PowerShell/issues/3405, `Out-Default -Transcript` emits output to pipeline | ||
| # as running in Pester effectively wraps everything in parenthesis, workaround is to use another powershell | ||
| # to run the test script passed as a string | ||
| $powershell = "$PSHOME/powershell" | ||
| } | ||
|
|
||
| It "'Out-Default -Transcript' shows up in transcript, but not host" { | ||
| $script = @" | ||
| `$null = Start-Transcript -Path "$testdrive\transcript.txt"; | ||
| 'hello' | Microsoft.PowerShell.Core\Out-Default -Transcript; | ||
| 'bye'; | ||
| `$null = Stop-Transcript | ||
| "@ | ||
|
|
||
| & $powershell -c $script | Should BeExactly 'bye' | ||
| "TestDrive:\transcript.txt" | Should Contain 'hello' | ||
| } | ||
|
|
||
| It "Out-Default reverts transcription state when used more than once in a pipeline" { | ||
| & $powershell -c "Out-Default -Transcript | Out-Default -Transcript; 'Hello'" | Should BeExactly "Hello" | ||
| } | ||
|
|
||
| It "Out-Default reverts transcription state when exception occurs in pipeline" { | ||
| & $powershell -c "try { & { throw } | Out-Default -Transcript } catch {}; 'Hello'" | Should BeExactly "Hello" | ||
| } | ||
|
|
||
| It "Out-Default reverts transcription state even if Dispose() isn't called" { | ||
| $script = @" | ||
| `$sp = {Out-Default -Transcript}.GetSteppablePipeline(); | ||
| `$sp.Begin(`$false); | ||
| `$sp = `$null; | ||
| [GC]::Collect(); | ||
| 'hello' | ||
| "@ | ||
| & $powershell -c $script | Should BeExactly 'hello' | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are not you supposed to call
base.InternalDispose()at some point of overriding method?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're correct. Will fix.