Skip to content

Conversation

@SteveL-MSFT
Copy link
Member

It appears that Pester is causing PowerShell to reflect on the Win32.Registry type which causes a type initialization exception even if not being used on Linux. Changed usage of registry to psdrive to avoid this problem.

Addresses #3098

@daxian-dbw
Copy link
Member

This if((-not ($skipTest)) -and $IsWindows) block was introduced because our default-browser-discovery code, which was used in Get-Help -Online, doesn't work correctly on the Azure code-coverage VM (see PR #3051). After #3281, that code was repalced by calling into ShellExecuteEx. Although I never tried on the Azure code-coverage VM, I think the problem should be solved, and if that's the case, this if block can be removed completely.

@vors
Copy link
Collaborator

vors commented Mar 21, 2017

LGTM, I'm going to re-assign it to Dongbo. If he is right that we don't need this code, it would be better to remove it completely.

@vors vors requested review from daxian-dbw and removed request for vors March 21, 2017 01:25
@SteveL-MSFT
Copy link
Member Author

@daxian-dbw since this is blocking nightly's from passing, we should make a call on this sooner than later. perhaps we should merge this to get it passing and separately see if the code is still needed for CC?

@daxian-dbw
Copy link
Member

@SteveL-MSFT that sounds reasonable. #3079 is tracking this issue.

@daxian-dbw daxian-dbw merged commit d59a71f into PowerShell:master Mar 21, 2017
@SteveL-MSFT SteveL-MSFT deleted the helpsystem branch March 21, 2017 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants