Update all W3 links in the resource files to use HTTPS instead of HTTP #3331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravisEz13
approved these changes
Mar 14, 2017
Member
|
Is there any test we can add to catch any new HTTP URLs added to the product code? |
TravisEz13
requested changes
Mar 14, 2017
Member
There was a problem hiding this comment.
We could add a meta test suite and use a regex to validate we use https: and not http:
DSC Resources have some meta tests (not for something exactly like this):
https://github.com/PowerShell/DscResource.Tests/blob/dev/Meta.Tests.ps1
Author
|
I created an issue to add some way to verify if new HTTP links have been added to the product code. |
TravisEz13
approved these changes
Mar 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.