fixed drifting of progress bar on Unix #3289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uses the progress to slowly move to the right in certain cases addresses PowerShell#3202
lzybkr
approved these changes
Mar 9, 2017
Contributor
lzybkr
left a comment
lzybkr
left a comment
There was a problem hiding this comment.
I'm not sure it's worth adding a test for this.
The code doesn't change frequently, and it's difficult to test.
Member
Author
|
@lzybkr it's also something easily noticed by people using PowerShell if it's not working :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
progress bar was incorrectly setting the original x position which causes the progress to slowly move to the right in certain cases
addresses #3202
need some suggestions on how to add a test for this