Skip to content

Conversation

@PetSerAl
Copy link
Contributor

Closes #3222

@msftclas
Copy link

@PetSerAl,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@daxian-dbw
Copy link
Member

#3230 is opened to track other *.generated.cs files.

Context "Get-TypeData" {
It "System.Array" {
(Get-TypeData System.Array).TypeName | Should Be System.Array
Get-TypeData System.Array | Should Be $null
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this test? Maybe remove?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just add it by analogy to other existing test. If you think, that it is not necessary here, then I can remove that last commit.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this test using on-page edit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daxian-dbw You could just remove one last commit.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PetSerAl Yes. I made this change with the online editor. But I'm going to squash and merge, so it should be fine.

@daxian-dbw daxian-dbw merged commit c490e36 into PowerShell:master Mar 1, 2017
@daxian-dbw
Copy link
Member

@PetSerAl Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants