Skip to content

Fix get-help online test #3051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daxian-dbw merged 7 commits into from
Feb 2, 2017
Merged

Fix get-help online test #3051

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2155832
Fix get-help online test
adityapatwardhan Jan 26, 2017
7c3e7bc
Address code review comments
adityapatwardhan Jan 26, 2017
23e5544
Fixed formatting
adityapatwardhan Jan 26, 2017
ee90d01
Fixed bugs in null check and variable name
adityapatwardhan Jan 26, 2017
9c5cb22
Addressed code review comments
adityapatwardhan Jan 26, 2017
24d7b8a
Addressed code review comments
adityapatwardhan Jan 30, 2017
fe64542
Added comment linking to the issue
adityapatwardhan Feb 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 32 additions & 1 deletion test/powershell/engine/Help/HelpSystem.OnlineHelp.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,39 @@ Describe 'Get-Help -Online opens the default web browser and navigates to the cm
$skipTest = [System.Management.Automation.Platform]::IsIoT -or
[System.Management.Automation.Platform]::IsNanoServer

It "Get-Help get-process -online" -skip:$skipTest {
# this code is a workaround for issue: https://github.com/PowerShell/PowerShell/issues/3079
if((-not ($skipTest)) -and $IsWindows)
{
$skipTest = $true
$regKey = "HKEY_CURRENT_USER\Software\Microsoft\Windows\Shell\Associations\UrlAssociations\http\UserChoice"

try
{
$progId = [Microsoft.Win32.Registry]::GetValue($regKey, "ProgId", $null)
if($progId)
{
$browserKey = [Microsoft.Win32.Registry]::ClassesRoot.OpenSubKey("$progId\shell\open\command", $false)
if($browserKey)
{
$browserExe = ($browserKey.GetValue($null) -replace '"', '') -split " "

if ($browserExe.count -ge 1)
{
if($browserExe[0] -match '.exe')
{
$skipTest = $false
}
}
}
}
}
catch
{
# We are not able to access Registry, skipping test.
}
}

It "Get-Help get-process -online" -skip:$skipTest {
{ Get-Help get-process -online } | Should Not Throw
}
}
Expand Down