Skip to content

Add PowerShell 7.8 to #requires version tests - #28402

Merged
Dongbo Wang (daxian-dbw) merged 2 commits into
masterfrom
jshigetomi-fix-packaging-tests
Nov 11, 2026
Merged

Dongbo Wang (daxian-dbw) merged 2 commits into
masterfrom
jshigetomi-fix-packaging-tests

Conversation

@jshigetomi

@jshigetomi Justin Chung (jshigetomi) commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • add PowerShell 7.8 to the explicit supported-version test cases
  • make 7.9 the next unsupported minor-version test case

This fixes the cross-platform Check for version 7.8 failures seen in #28396 and other PRs after master advanced to PowerShell 7.8.

Validation

  • Confirmed the PR diff is a one-line addition of 7.8 to Requires.Tests.ps1
  • The complete test cannot pass under the locally installed PowerShell 7.6 because 7.8 is correctly unsupported there; CI runs it against the repository's PowerShell 7.8 build

Generate valid PowerShell 7 minor versions from the runtime version so the next minor is tested as unsupported without becoming stale at each release transition.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@jshigetomi
Justin Chung (jshigetomi) requested a review from a team as a code owner November 11, 2026 19:34
Copilot AI balanced review requested due to automatic review settings November 11, 2026 19:34
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the runtime-derived version test changes.

No open issues 🎉

What changed in this PR

Updates the #requires -Version tests to follow the running PowerShell version, preventing false failures when development advances to a new release, as seen in #28396.

Changes:

  • Generates supported minor versions for the runtime’s major version instead of maintaining a fixed list.
  • Derives unsupported minor and major versions from the runtime version.
File Description
test/​powershell/​Language/​Scripting/​Requires.Tests.ps1 Replaces hardcoded version boundaries with runtime-derived test cases.

Review effort: Balanced

Add PowerShell 7.8 to the explicit supported-version list.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@jshigetomi Justin Chung (jshigetomi) changed the title Fix #requires version tests for current release Add PowerShell 7.8 to #requires version tests Nov 11, 2026
@jshigetomi Justin Chung (jshigetomi) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Nov 11, 2026
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 1f9cf34 into master Nov 11, 2026
61 of 72 checks passed
@daxian-dbw
Dongbo Wang (daxian-dbw) deleted the jshigetomi-fix-packaging-tests branch November 11, 2026 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants