Repository navigation
Validate remote module names before Import-Module - #28401
Open
Justin Chung (jshigetomi) wants to merge 2 commits into
Open
Justin Chung (jshigetomi) wants to merge 2 commits into
Justin Chung (jshigetomi) wants to merge 2 commits into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Justin Chung (jshigetomi)
added
the
CL-General
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new module-name validation lacks regression coverage for invalid names and platform-specific handling, leaving its error behavior and prevention of local proxy-file creation unverified.
1 open issue
What changed in this PR
Adds protective validation before Import-Module -PSSession uses remote module names to construct local proxy-module paths.
Changes:
- Rejects null/empty names, path separators,
./.., and colons on Windows. - Reports an error and skips rejected modules before constructing local paths.
| File | Description |
|---|---|
| src/System.Management.Automation/resources/Modules.resx | Adds the error message for rejected module names. |
| src/System.Management.Automation/engine/Modules/ImportModuleCommand.cs | Validates remote module names before local path construction. |
Review effort: Balanced
| Version remoteModuleVersion, | ||
| PSSession psSession) | ||
| { | ||
| if (string.IsNullOrEmpty(remoteModuleName) || remoteModuleName.IndexOfAny(s_pathTraversalChars) >= 0 || remoteModuleName is "." or "..") |
Justin Chung (jshigetomi)
changed the title
Justin Chung (jshigetomi)
changed the title
| ['\\', '/']; | ||
| #else | ||
| ['\\', '/', ':']; | ||
| #endif |
Collaborator
There was a problem hiding this comment.
You could use specific API like ContainsAny()
https://source.dot.net/#System.Private.CoreLib/src/runtime/src/libraries/System.Private.CoreLib/src/System/MemoryExtensions.cs,479
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Context
PR Checklist