Skip to content

[release/v7.7.0] Fix the resource string WeakCatalogHashAlgorithm - #28368

Merged
Dongbo Wang (daxian-dbw) merged 1 commit into
release/v7.7.0from
backport/release/v7.7.0/28322-3209d2a64
Nov 6, 2026
Merged

Dongbo Wang (daxian-dbw) merged 1 commit into
release/v7.7.0from
backport/release/v7.7.0/28322-3209d2a64

Conversation

@jshigetomi

Copy link
Copy Markdown
Collaborator

Backport of #28322 to release/v7.7.0

Triggered by Justin Chung (@jshigetomi) on behalf of Dongbo Wang (@daxian-dbw)

Original CL Label: CL-BuildPackaging

/cc @PowerShell/powershell-maintainers

Impact

Tooling Impact

  • Required tooling change
  • Optional tooling change (include reasoning)

Customer Impact

  • Customer reported
  • Found internally

Corrects the WeakCatalogHashAlgorithm warning to accurately identify version 1 catalogs and the weak SHA-1 hash algorithm, removing the incorrect SHA0 reference. Adds localization guidance preserving SHA-1 and -CatalogVersion 2 in translations.

Regression

  • Yes
  • No

Corrects inaccurate warning wording introduced by #27805, whose prerequisite warning change is already present in release/v7.7.0 through merged backport #28358.

Testing

The original PR's resource text and localization comment were applied by a clean cherry-pick with no conflicts. Local tests were not run; backport CI must pass before merge.

Risk

  • High
  • Medium
  • Low

Changes only resource text and a localization comment; no executable code or catalog validation behavior changes.

@jshigetomi
Justin Chung (jshigetomi) requested a review from a team as a code owner November 6, 2026 03:02
@jshigetomi Justin Chung (jshigetomi) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Nov 6, 2026
Copilot AI balanced review requested due to automatic review settings November 6, 2026 03:02
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@jshigetomi Justin Chung (jshigetomi) changed the title Fix the resource string WeakCatalogHashAlgorithm (#28322) [release/v7.7.0] Fix the resource string WeakCatalogHashAlgorithm Nov 6, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the catalog-warning text correction and localization guidance.

No open issues 🎉

What changed in this PR

Backports #28322 to release/v7.7.0, correcting the file-catalog warning introduced by the earlier SHA-1 warning backport. No executable code or catalog validation behavior changes.

Changes:

  • Identifies version 1 catalogs as using the weak SHA-1 algorithm, removing the incorrect SHA0 reference.
  • Adds localization guidance to preserve SHA-1 and -CatalogVersion 2.
File Description
src/​System.Management.Automation/​resources/​CatalogStrings.resx Corrects the warning text and adds localization guidance.

Review effort: Balanced

@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit b877cd8 into release/v7.7.0 Nov 6, 2026
38 checks passed
@daxian-dbw
Dongbo Wang (daxian-dbw) deleted the backport/release/v7.7.0/28322-3209d2a64 branch November 6, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants