Repository navigation
[release/v7.7.0] Fix the regex in ConsoleHost.Tests.ps1 used to verify help content - #28365
Merged
Justin Chung (jshigetomi) merged 1 commit intoNov 6, 2026
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Justin Chung (jshigetomi)
added
the
CL-Test
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the test-only correction to the ConsoleHost help-output assertion.
No open issues 🎉
What changed in this PR
Backports #28308 to release/v7.7.0, correcting the ConsoleHost help-output test so unrelated output no longer satisfies its assertion. This is a test-only change.
Changes:
- Escapes regex metacharacters to match the literal help syntax.
- Updates the expected usage text to include
-h.
| File | Description |
|---|---|
test/powershell/Host/ConsoleHost.Tests.ps1 |
Corrects the regex used to validate output from help parameters. |
Review effort: Balanced
Justin Chung (jshigetomi)
enabled auto-merge (squash)
November 5, 2026 20:00
Dongbo Wang (daxian-dbw)
approved these changes
Nov 5, 2026
Dongbo Wang (daxian-dbw)
left a comment
Dongbo Wang (daxian-dbw)
left a comment
Member
There was a problem hiding this comment.
Copilot CLI reviewed this backport and confirmed that its changes match the original PR, #28308, as merged into master.
auto-merge was automatically disabled
November 6, 2026 02:16
Pull request was closed
Justin Chung (jshigetomi)
changed the title
ConsoleHost.Tests.ps1 used to verify help content.ConsoleHost.Tests.ps1 used to verify help content
Justin Chung (jshigetomi)
merged commit Nov 6, 2026
c9b051f
into
release/v7.7.0
69 of 70 checks passed
Dongbo Wang (daxian-dbw)
deleted the
backport/release/v7.7.0/28308-01b9a93c3
branch
November 6, 2026 18:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #28308 to release/v7.7.0
Triggered by Justin Chung (@jshigetomi) on behalf of Dongbo Wang (@daxian-dbw)
Original CL Label: CL-Test
/cc @PowerShell/powershell-maintainers
Impact
Tooling Impact
Optional because this is a test-only correctness fix.
Regression
This is not a regression.
Testing
The original PR corrects the regex used to verify help content, and the cherry-pick applied conflict-free. CI validation is required.
Risk
Low risk because this is a test-only change.